Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Website Favicons within Piwik interface #3366

Open
julienmoumne opened this issue Sep 7, 2012 · 10 comments
Open

Display Website Favicons within Piwik interface #3366

julienmoumne opened this issue Sep 7, 2012 · 10 comments
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. c: New plugin For features that probably will not be added to Matomo, but could be implemented as plugins. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.

Comments

@julienmoumne
Copy link
Member

In Websites Management, allow user to specify a favicon for the website.

Include the uploaded favicon, if available, in report metadata <logo/> markup.

The favicon would be displayed wherever applicable such as :

  • All Websites
  • In PDF&HTML reports and Piwik Mobile when plotting evolution PNG charts for MultiSites.getAll
@mattab
Copy link
Member

mattab commented Sep 7, 2012

We could propose this feature enabled by default, the favicon would be http fetched and cached in tmp/assets/favicon/ for example, refreshed once per week, displayed in All Websites (instead of the outgoing orange icon), and in the Static Evolution Graphs.
It that will increase piwik reports look and ease the analysis. Great idea.

@mattab
Copy link
Member

mattab commented Dec 15, 2012

We could use:

To get the favicon for any site? and cache the favicon locally in Piwik..

This would have some "privacy" concerns because then the website getfavicon.appspot would know that the user is related to the requested websites. Alternatively, Piwik could http fetch the favicon automatically (but it requires to parse the homepage then query the favicon which is more complicated and painful).

So I would say

  • Settings disabled by default
  • When enabled, use getfavicon.appspot service and cache favicon locally

@hpvd
Copy link

hpvd commented Apr 6, 2016

#10016 gives some more/other details to setup and usage of favicons

@hpvd
Copy link

hpvd commented Apr 6, 2016

hmm -why is there an external service needed to fetch favicon if we have the url?

would vote for finding a solution to make favicon fetching (e.g. Button click, see #10016) & showing without any privacy concerns and with this enabled by default.
-> would enchance usability and look a lot

@tsteur
Copy link
Member

tsteur commented Apr 6, 2016

hmm -why is there an external service needed to fetch favicon if we have the url?

I reckon because there could be different favicon (ico, png, ...) and via HTML you can even define a custom path so we'd need to parse HTML under circumstances to find correct favicon etc. I presume that was the thought behind using a service for it. A basic version could be implemented without external service though I presume.

@tsteur
Copy link
Member

tsteur commented Apr 6, 2016

The favicon would be displayed wherever applicable such as :

as @hpvd mentioned in #10016 could be also shown in website selector etc.

@hpvd
Copy link

hpvd commented Apr 7, 2016

+1 for basic version without any external tool (first step) after that we could thing again of how to make next step...

@hpvd
Copy link

hpvd commented Apr 7, 2016

extracted from #10016
Show website's favicon in website selector + on other places with website-name


Showing website's favicon in website selector would give selecting website better usability and a more individual "here I'm home"(-> I see my websites favicon) look.
Show

  • for selected website
  • in dropdown

please see attachment

Maybe this could be simply fetched and stored during site setup
on Administration/Websites/Manage websites when clicking save button
(plus always refetch the latest version on every click of this button)

2016-04-06_20h26_09

from comment in #10016:
of course this favicon could not be only shown in website selctor, but also on all places where website name is mentioned...
e.g. Administration/Websites/


from comment in #10016:
if one would make it even more universal, one could provide on
Administration/Websites/Manage websites
2 Buttons/function:

  • fetch favicon
  • upload individual icon

(instead of coupeling with save-button as proposed above)


@hpvd
Copy link

hpvd commented Apr 7, 2016

@mattab , @tsteur

just had a look at github and serached for "favicon"
https://github.com/search?utf8=%E2%9C%93&q=favicon

=> there seem to be many solutions available without any "external service" need to fetch favicon...
(so there is no need to start with only a basic integration of this)

@tsteur
Copy link
Member

tsteur commented Apr 7, 2016

Yeah that's probably a better idea to use a lib and not to rely on an external service for this re privacy and any external service might also not exist forever 👍

@mattab mattab changed the title Support for Website Favicons Display Website Favicons within Piwik interface Jul 14, 2016
@mattab mattab modified the milestones: Long term, Mid term Dec 5, 2016
@Findus23 Findus23 added c: Design / UI For issues that impact Matomo's user interface or the design overall. c: New plugin For features that probably will not be added to Matomo, but could be implemented as plugins. labels Dec 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c: Design / UI For issues that impact Matomo's user interface or the design overall. c: New plugin For features that probably will not be added to Matomo, but could be implemented as plugins. Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

5 participants