New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect Mobile scaled Resolution via window.devicePixelRatio #3416
Comments
The screen resolution is captured by Piwik.js. It doesn't look at the user agent, so it has no way of knowing that Mobile Safari is lying. |
We could use window.devicePixelRatio to scale the resolution. But I loathe using Apple's window.orientation or orientationchange event when other browsers are supporting the draft standard deviceorientation event. |
By the way, the same goes for the iPad 3, which is recognized with 768x1024 while it is 2048 x 1536px actually. |
(In [7319]) fixes #3416 - scale resolution by window.devicePixelRatio on Safari iOS/Mac OS X |
FYI change reverted in #10296 (comment) as applying the device pixel ratio resulted in resolution incorrectly stored. |
Piwik currently has an issue with correctly detecting an iPhone 5 and shows a wrong display size in the logs:
iPhone / Safari / 320x568
The correct size would be 1136 x 640px.
Find the iPhone5 user agent string below:
The text was updated successfully, but these errors were encountered: