Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detecting site search via URL parameter with square brackets does not work #3454

Closed
anonymous-matomo-user opened this issue Oct 18, 2012 · 5 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@anonymous-matomo-user
Copy link

When detecting site search via URL, we have a similar problem as mentioned in #3201 and fixed with #3187. If the site search query parameter contains square brackets (e.g. search[q]), it is not recognized if the URL is urlescaped. The patch (similar to #3187) I attached fixes the problem for me. But I am not sure if there isn't a better place to take care of the square brackets. Thanks for having a look!
Keywords: sitesearch

@anonymous-matomo-user
Copy link
Author

Attachment:
Action.php.patch

@mattab
Copy link
Member

mattab commented Oct 18, 2012

Thanks for report

@mattab
Copy link
Member

mattab commented Nov 9, 2012

can you please try with 1.9.2-beta from:

For me it is working by specifying the parameter "s" which will track &s[]=search

what exactly is not working for you & that your patch fixes?

@anonymous-matomo-user
Copy link
Author

Thanks for getting back to this. The problem still exists in the trunk. To reproduce, please use a url-encoded parameter name (sorry I didn't mention this before), e.g. ?param%5Bsearch%5D=test. It's the same problem as in #3201.

@mattab
Copy link
Member

mattab commented Nov 22, 2012

(In [7521]) Site search improvements

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants