#3454 closed Bug (fixed)

Detecting site search via URL parameter with square brackets does not work

Reported by: theilm Owned by: matt
Priority: normal Milestone: 1.10 - Piwik 1.10
Component: Core Keywords: sitesearch
Cc: Sensitive: no

Description

When detecting site search via URL, we have a similar problem as mentioned in #3201 and fixed with #3187. If the site search query parameter contains square brackets (e.g. search[q]), it is not recognized if the URL is urlescaped. The patch (similar to #3187) I attached fixes the problem for me. But I am not sure if there isn't a better place to take care of the square brackets. Thanks for having a look!

Attachments (1)

Action.php.patch (666 bytes) - added by theilm 18 months ago.

Download all attachments as: .zip

Change History (5)

Changed 18 months ago by theilm

comment:1 Changed 18 months ago by matt (mattab)

  • Milestone changed from 1.9.x - Piwik 1.9.x to 1.9.1 - Piwik 1.9.1
  • Owner set to matt

Thanks for report

comment:2 Changed 18 months ago by matt (mattab)

can you please try with 1.9.2-beta from:

For me it is working by specifying the parameter "s" which will track &s[]=search

what exactly is not working for you & that your patch fixes?

comment:3 Changed 18 months ago by theilm

Thanks for getting back to this. The problem still exists in the trunk. To reproduce, please use a url-encoded parameter name (sorry I didn't mention this before), e.g. ?param%5Bsearch%5D=test. It's the same problem as in #3201.

comment:4 Changed 17 months ago by matt (mattab)

  • Resolution set to fixed
  • Status changed from new to closed

(In [7521]) Site search improvements

  • Support &kwd[]= notation fixes #3454
  • Support random text case fixes #3539
  • Fixes umlauts regression with non utf8 encoding: Fixes #3450
  • Adding setPageCharset() method to Tracking API FIxes #3565
Note: See TracTickets for help on using tickets.