Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GeoIP fails silently when mbstring extension not available #3473

Closed
mattab opened this issue Oct 23, 2012 · 1 comment
Closed

GeoIP fails silently when mbstring extension not available #3473

mattab opened this issue Oct 23, 2012 · 1 comment
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Oct 23, 2012

Reported in forums.

We should

  • Remove silent fail @ operator in all GeoIP drivers
  • Update the System check, to add a warning that, when the extension mbstring is not available or enabled, geoIP will not work
  • It would be nice & important to ensure that, any error happening during GeoIP tracking, would alos be surfaced in the GeoIP tooltips on the admin page, so that users can see the errors in the UI and do not have to debug the tracking requests to see the errrors.
@diosmosis
Copy link
Member

(In [7290]) Fixes #3473, add "GeoIP won't work" warning to installation system check for mbstring, make sure GeoIP (Php) implementation checks for mbstring plugin, and remove silent fail calls in GeoIP plugins.

@mattab mattab added this to the 1.9.1 - Piwik 1.9.1 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants