#3482 closed Bug (fixed)

Setting 'archiving_ranking_query_row_limit' to 0 (no limit) should disable RankingQuery

Reported by: matt Owned by: matt
Priority: major Milestone: 1.12 - The Great 1.x Backlog
Component: Core Keywords:
Cc: Sensitive: no

Description (last modified by matt)

Setting
'archiving_ranking_query_row_limit' to 0 (no limit) causes archiving
process not to process Actions and display an error.

The following errors shows up during archiving:

Notice:</strong> <i>Undefined index: type</i> in
<b>/home/ehealth/public_html/piwik/plugins/Actions/ArchivingHelper.php</b>
on line <b>49</b>
<br /><br />Backtrace --&gt;<div style="font-family:Courier;font-
size:10pt"><br />
#0  Piwik_ErrorHandler(...) called at
[/home/ehealth/public_html/piwik/plugins/Actions/ArchivingHelper.php:49]<br
/>
#1  Piwik_Actions_ArchivingHelper::updateActionsTableWithRowQuery(...)
called at
[/home/ehealth/public_html/piwik/plugins/Actions/Archiving.php:478]<br />
#2  Piwik_Actions_Archiving-&gt;archiveDayQueryProcess(...) called at
[/home/ehealth/public_html/piwik/plugins/Actions/Archiving.php:282]<br />
#3  Piwik_Actions_Archiving-&gt;archiveDayActionsTime(...) called at
[/home/ehealth/public_html/piwik/plugins/Actions/Archiving.php:100]<br />
#4  Piwik_Actions_Archiving-&gt;archiveDay(...) called at
[/home/ehealth/public_html/piwik/plugins/Actions/Actions.php:592
...

var_dump'ing $row at plugins/Actions/ArchivingHelper.php:36, shows:

array(6) {
  ["idaction"]=>
  string(7) "1792657"
  [17]=>
  string(1) "1"
  [19]=>
  string(1) "1"
  [20]=>
  string(1) "3"
  [21]=>
  string(3) "279"
  [22]=>
  string(1) "0"
}

so we have a problem with translation of keys in the row.

Change History (3)

comment:1 Changed 12 months ago by matt (mattab)

  • Description modified (diff)
  • Summary changed from Setting 'archiving_ranking_query_row_limit' to 0 (no limit) causes archiving process not to process Actions. to Setting 'archiving_ranking_query_row_limit' to 0 (no limit) should disable RankingQuery

comment:2 Changed 12 months ago by matt (mattab)

Proposal

  • when archiving_ranking_query_row_limit == 0, throw an exception (ask user to increase value in config file)
  • in the code, remove the code that tests for RQ and always use it in Actions+Transitions plugins (where it is currently used)
    • the feature "disable ranking query" is actually not a feature of Piwik, so let's remove it.

To record more or all data, set this number to very high limit ie. 100000 or 1 million.

comment:3 Changed 12 months ago by capedfuzz (diosmosis)

  • Resolution set to fixed
  • Status changed from new to closed

In 4b4277b3acab454b69ded4557deba3271ff93b9b:

Fixes #3482, apply quick fix so Piwik works when ranking query is disabled and added test for disabled ranking query. Added FIXME comment to make sure underlying issue is eventually dealt with.

Note: See TracTickets for help on using tickets.