Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column names not translated when switch from graph to table #3498

Closed
mattab opened this issue Oct 30, 2012 · 0 comments
Closed

Column names not translated when switch from graph to table #3498

mattab opened this issue Oct 30, 2012 · 0 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. worksforme The issue cannot be reproduced and things work as intended.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Oct 30, 2012

Reported in forums

  1. Add custom variables report
  2. Switch to graph
  3. Add 'conversions' to graph (button on top of graph)
  4. Switch to table
  5. nb_conversions column present on table

Solution: we should translate all column names even those unused.

Also I think we could really simplify the whole code of AddColumnsMetrics* since it's confusing and not very modular nor loosely coupled.

The viewDataTable=tableGoals should only be a proxy to the set of columns to display. The views would also work when columns are manually specified via &columns= and would be then processed from the raw columns, in one main AddProcessedColumnsFilter with a list of a columns as input, which will call other smaller filters to add new and processed and goal metrics.

This simplification / refactoring of code around management of columns and metrics would for sure be helpful in many ways in the future, such as building Custom Reports and adding Custom Metrics via hooks that would add the Metadata metrics information, but could also easily hook the new metrics SQL inside the core archiving query.

This would also be useful for later defining new Custom Dimensions based on Custom Variables, but with their own reports and set of metrics.

@mattab mattab added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

1 participant