Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with Goals plugin disabled, VisitSummary still shows metrics nb_visits_converted #3510

Closed
anonymous-matomo-user opened this issue Nov 3, 2012 · 3 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone

Comments

@anonymous-matomo-user
Copy link

Bug in 'Visitor Overview'.
Steps to reproduce:

  1. Disable Plugin 'Goals'
  2. Show 'Visitors' > 'Overview'
  3. Click on Icon 'Metrics to plot' (positioned after title 'Evolution over the period')

Item 'nb_visits_converted' is shown (but has no data).

Hint to source correction:
dont fill 'nb_visits_converted' into $selectableColumns in plugins\VisitSummary\Controller.php without checking the plugin in lines 59-75.

Lousy example to patch:

#!python 
$selectableColumns = array(
    // columns from VisitsSummary.get
    'nb_visits',
    'nb_uniq_visitors',
    'avg_time_on_site',
    'bounce_rate',
    'nb_actions_per_visit',
    'max_actions');
$displaygoals = Piwik_PluginsManager::getInstance()->isPluginActivated('Goals');
if($displaygoals) {
    $selectableColumns[] = 'nb_visits_converted';
}
// columns from Actions.get
$selectableColumns[] ='nb_pageviews';
$selectableColumns[] ='nb_uniq_pageviews';
$selectableColumns[] ='nb_downloads';
$selectableColumns[] ='nb_uniq_downloads';
$selectableColumns[] ='nb_outlinks';
$selectableColumns[] ='nb_uniq_outlinks';

$idSite = Piwik_Common::getRequestVar('idSite');

Keywords: VisitSummary nb_visits_converted Goals

@mattab
Copy link
Member

mattab commented Nov 3, 2012

Thanks for the report. Are you using Piwik with goals plugin disabled? Have you found other problems ?

@anonymous-matomo-user
Copy link
Author

There are two installations. The tracking code points to the first installation, plugins enabled/disabled as usual (from default installation). The second installation takes its data from the same database, but noone is tracking and only a few plugins (Actions, Dashboard, Login, VisitSummary, Widgetize) are enabled.

For the second installation I dont care about any problems outside the visitors overview page. Because the installed version is not up to date (1.8.4), I also cannot really tell you if disabling the goals plugin works in general.

But i've made some short tests this morning.

  1. a new local installation (Version 1.9.1), plugin goals disabled, then data generated by plugin VisitorGenerator. Bad idea. Most widgets show nothing. It seems like it is not advisable to disable goals.
  2. The other way: new local installation (Version 1.9.1), data generated by plugin VisitorGenerator, then plugin goals disabled.

I've seen the following problems:

  • widget 'visits over time' tries to show 'Visits with Conversions'
  • widget 'Visits by Server Time' tries to show 'Conversions'.
  • widget 'Visits overview (with graph)' tries to show 'Visits with Conversions'

But don't waste too much time on this if it gets too complicated. I'm aware of the rare occasions of installations with disabled goals plugin.

@mattab
Copy link
Member

mattab commented Nov 6, 2012

visitor generator requires all plugins enabled

@anonymous-matomo-user anonymous-matomo-user added this to the 1.9.2 - Piwik 1.9.2 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

2 participants