Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoalManager: misspelled variable leads to incorrect attribution #3550

Closed
christianfutterlieb opened this issue Nov 16, 2012 · 4 comments
Closed
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@christianfutterlieb
Copy link

To me it seems very likely that this is not wanted. Because with the uninitialized variable $refererCampaignName Campaign data are always taken from $visitorInformation (if $visitorInformation has a campaign registered). Please take a look at the patch.

@christianfutterlieb
Copy link
Author

Attachment:
GoalManager-3550.diff

@robocoder
Copy link
Contributor

(In [7485]) fixes #3550 referrerCampaignName typo; thanks Christian

@mattab
Copy link
Member

mattab commented Nov 20, 2012

oh very cool find, thanks so much, this bug was reported over the last months and I never found the cause, Cheers! Please keep patches like this coming ;-)

@christianfutterlieb
Copy link
Author

!^!^ .. I'm glad to be able to give something back

@christianfutterlieb christianfutterlieb added this to the 1.10 - Piwik 1.10 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

3 participants