Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] create better way to associate metric names w/ the plugins that process them #3560

Closed
diosmosis opened this issue Nov 21, 2012 · 2 comments
Closed

[refactor] create better way to associate metric names w/ the plugins that process them #3560

diosmosis opened this issue Nov 21, 2012 · 2 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.

Comments

@diosmosis
Copy link
Member

Currently Piwik_Archive_Single::getRequestedReportFor is (very indirectly) used to associate metric names w/ the plugins that process them. It employ three hacks, returns a 'report' name which contains the plugin name. ArchiveProcessing splits the report name and returns the plugin name. This is convoluted and the code is just a bunch of hacks so it should probably be changed.
@mattab
Copy link
Member

mattab commented Nov 22, 2012

good point

@mattab
Copy link
Member

mattab commented Jan 13, 2014

I believe this was fixed in 2.0

@diosmosis diosmosis added this to the Future releases milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@diosmosis @mattab