Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

trunk: ArchiveProcessingTest detect when bulk insert is testable #3605

Closed
robocoder opened this issue Dec 12, 2012 · 8 comments
Closed

trunk: ArchiveProcessingTest detect when bulk insert is testable #3605

robocoder opened this issue Dec 12, 2012 · 8 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
1.10

Comments

@robocoder
Copy link
Contributor

The ArchiveProcessing test using Mysqli is passing when using LOAD DATA INFILE, so it isn't a MySQL / AppArmor configuration issue. (I also checked that the "piwik" db user has the FILE privilege.)

On the VM, the mysqli.so and pdo_mysql.so extensions both appear to use libmysqlclient. On dev6, our 5.3.x builds used the new mysqlnd (native driver) extension.

So, this points to a pdo_mysql bug ... i.e.,
@robocoder
Copy link
Contributor Author

(In [7600]) fixes #3605 - add detection for mysqlnd

@robocoder
Copy link
Contributor Author

(In [7601]) refs #3605 - correct information in phpdocs

@mattab
Copy link
Member

mattab commented Dec 12, 2012

All in all, what is the minimum recommended php version? is the latest 5.3.x enough to enjoy LOAD DATAINFILE. Since it's a big improvement boost, we could add it in the system check list as a "warning" - high traffic users will want to know this setting.

Otherwise this ticket cna be closed since tests pass? Thanks so much for finding this info it was doing my head in! we are going green

@robocoder
Copy link
Contributor Author

Minimum:

  • 5.2.1+ with mysqli
  • 5.3.9+ with pdo_mysql using mysqlnd

Maximum:

  • 5.2.8 with pdo_mysql using libmysqlclient

@mattab
Copy link
Member

mattab commented Dec 13, 2012

Thanks added comment in: #2122

@mattab
Copy link
Member

mattab commented Dec 16, 2012

@vipsoft I would like to follow up [7600] and add a warning if box is Jenkins AND isBulkInsertTestable() returns false (since we should know when jenkins stops running these tests). how could we detect if the current server is Jenkins?

@mattab
Copy link
Member

mattab commented Dec 21, 2012

(In [7677]) Fixes #3605 Marking the test as "skipped" even if it's not testable.

This will be annoying to always see it in the test output so I probably disable it for jenkins later

@mattab
Copy link
Member

mattab commented Dec 21, 2012

(In [7678]) refs #3605 #2122 Claryfying mesage when load data in file not working

@robocoder robocoder added this to the 1.10 - Piwik 1.10 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
1.10
Development

No branches or pull requests
2 participants
@mattab @robocoder