Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new parmeter &pattern= to MultiSites.getAll to allow searching for websites #3636

Closed
tsteur opened this issue Dec 21, 2012 · 4 comments
Closed

Add new parmeter &pattern= to MultiSites.getAll to allow searching for websites #3636

tsteur opened this issue Dec 21, 2012 · 4 comments
Assignees
@mattab
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone
1.12

Comments

@tsteur
Copy link
Member

tsteur commented Dec 21, 2012

Hi,

for new Piwik Mobile version, I need a MultiSite enhancement. Talked with some Piwik users and we need to improve the "Available Websites" view in next version. It'll be more like an "All Websites Dashboard". Usually, I'd just use MultiSites.getAll, but I need the possibility to search for websites. Because some users have thousands of websites.

Is it possible to
a) Add a parameter "pattern" to MultiSite.getAll to return only websites, that matches the given pattern. Similar to "SitesManager.getPatternMatchSites"?
b) Add a new method MultiSite.getPatternMatchSites(pattern, period, date, segment = , enhanced =)?

I need either a) or b). It also has to support "filter_limit" parameter.

On tablets, the "All websites dashboard" view will nearly display all data returned by the MultiSites API. Of course, I could use method "SitesManager.getPatternMatchSites" to fetch list of available websites and then use MultiSites.getOne via "batch API requests". But I think this will be slow especially when requesting 50 websites. In addition, "SitesManager.getPatternMatchSites" returns lots of data I don't need. I just need idSite + website name which I'll get via MultiSite.

Is it possible to get this in the next 4 weeks? Is it difficult?
@mattab
Copy link
Member

mattab commented Jan 2, 2013

Working on it, good idea - will go for a)

@mattab
Copy link
Member

mattab commented Jan 3, 2013

(In [7717]) Fixes #3636 Hopefully I haven't broken anything!

Added new parmeter &pattern= to MultiSites.getAll

Thomas let me know if any feedback on this!

@tsteur
Copy link
Member Author

tsteur commented Feb 15, 2013

Think I've found a bug. If you're searching for a pattern that matches nothing, all websites are returned:

Example search for "piwifererser":

http://demo.piwik.org/index.php?hideMetricsDoc=1&showTimer=0&filter_limit=40&period=day&date=today&idSite=3&sortOrderColumn=nb_visits&filter_sort_column=nb_visits&apiModule=MultiSites&apiAction=getAll&pattern=piwifererser&module=API&token_auth=anonymous&format=json&method=API.getProcessedReport&language=en&

@mattab
Copy link
Member

mattab commented Apr 5, 2013

In 5001bdd: fixes #3636
Now returning zero result when no site matches the pattern
Sorry for the delay Thomas!

@tsteur tsteur added this to the 1.12 - The Great 1.x Backlog milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
2 participants
@tsteur @mattab