Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "!" to piwik.js to prevent compressor to remove the copyright comment, also add current piwik version number #3677

Closed
ryrun opened this issue Jan 16, 2013 · 1 comment
Closed

Add "!" to piwik.js to prevent compressor to remove the copyright comment, also add current piwik version number #3677

ryrun opened this issue Jan 16, 2013 · 1 comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Milestone
1.11

Comments

@ryrun
Copy link

ryrun commented Jan 16, 2013

We using a javascript compressor to minify and combine all javascripts to one file. The compressor remove all multiline comments, but not the ones which are starting with "/*!". Please add a "!"-sign to piwik.js, so your copyright will be still there and we can better check for the current version number. And also add the current version number to the js file. Thx.

See jquery javascript files...
http://code.jquery.com/jquery-1.9.0.min.js
@robocoder
Copy link
Contributor

We've gone back and forth on this. The current style reflects security "best practices" to minimize info disclosure that would allow identification of the Piwik version in use.

@ryrun ryrun added this to the 1.11 - Piwik 1.11 milestone Jul 8, 2014
@snyk-bot snyk-bot mentioned this issue Mar 29, 2020
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Milestone
1.11
Development

No branches or pull requests
2 participants
@robocoder @ryrun