#3690 closed Bug (fixed)

Log component: use fileFormatter when writing to file

Reported by: BrainCrumbz Owned by: mattab
Priority: normal Milestone: 1.11 - Piwik 1.11
Component: Core Keywords:
Cc: Sensitive: no

Description

In the Log component, addWriteToFile method, as in:
http://dev.piwik.org/trac/browser/trunk/core/Log.php#L56

the set formatter is $this->screenFormatter.

Shouldn't that be $this->fileFormatter instead?

Change History (3)

comment:1 Changed 15 months ago by matt (mattab)

  • Milestone set to 1.11 - Piwik 1.11
  • Priority changed from low to normal

it probably should indeed. Have you used it or just noticed it? we'll investigate

comment:2 Changed 15 months ago by BrainCrumbz

We've used that during some debug session. After the switch, we saw an output change from:

CACHE_CONTROL: max-age=0\r\nCONNECTION: keep-alive\r\n<br/>

to:

CACHE_CONTROL: max-age=0 CONNECTION: keep-alive

So the <br/> disappeared, but the \r\n were not replaced with actual carriage returns.

comment:3 Changed 15 months ago by matt (mattab)

  • Owner set to mattab
  • Resolution set to fixed
  • Status changed from new to closed

In 05de97edb5c92c86b2eb57439a55db86b371c1c7:

Fixes #3690 Thanks for the report & patch!

Note: See TracTickets for help on using tickets.