Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log component: use fileFormatter when writing to file #3690

Closed
BrainCrumbz opened this issue Jan 18, 2013 · 3 comments
Closed

Log component: use fileFormatter when writing to file #3690

BrainCrumbz opened this issue Jan 18, 2013 · 3 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@BrainCrumbz
Copy link

In the Log component, addWriteToFile method, as in:
https://github.com/piwik/piwik/blob/master/core/Log.php#L56

the set formatter is $this->screenFormatter.

Shouldn't that be $this->fileFormatter instead?

@mattab
Copy link
Member

mattab commented Jan 18, 2013

it probably should indeed. Have you used it or just noticed it? we'll investigate

@BrainCrumbz
Copy link
Author

We've used that during some debug session. After the switch, we saw an output change from:

CACHE_CONTROL: max-age=0\r\nCONNECTION: keep-alive\r\n<br/>

to:

CACHE_CONTROL: max-age=0 CONNECTION: keep-alive

So the &lt;br/> disappeared, but the \r\n were not replaced with actual carriage returns.

@mattab
Copy link
Member

mattab commented Feb 4, 2013

In 05de97e: Fixes #3690 Thanks for the report & patch!

@BrainCrumbz BrainCrumbz added this to the 1.11 - Piwik 1.11 milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants