Opened 15 months ago

Closed 13 months ago

Last modified 11 months ago

#3701 closed Bug (fixed)

Disabled Transitions Plugin leads to javascript error

Reported by: ts77 Owned by: diosmosis
Priority: normal Milestone: 1.12 - The Great 1.x Backlog
Component: Core Keywords:
Cc: ezdesign Sensitive: no

Description

If the transitions plugin is disabled you are getting a javascript error on most pages in the piwik ui:

ReferenceError: DataTable_RowActions_Transitions is not defined

...createInstance:function(dataTable){return new DataTable_RowActions_Overlay(dataT...

(Version 1.10.1)

Change History (9)

comment:1 Changed 15 months ago by matt (mattab)

  • Cc ezdesign added
  • Milestone set to 1.11 - Piwik 1.11

Thanks for the report!

comment:2 Changed 15 months ago by EZdesign (BeezyT)

The Overlay plugin depends on the Transitions plugin.

If want to you disable Transitions, you have to disable Overlay too. That should fix it. Can you try?

comment:3 Changed 15 months ago by ts77

sorry but that's not the point.
I had transitions disabled before, upgraded to a newer version where suddenly overlay was enabled - and nothing worked anymore because of javascript errors.
It took me a while to debug where these were coming from.
So please either:

  • automatically enable transitions when you automatically enable the overlay plugin
  • disable the overlay plugin when transitions are not enabled

It doesn't make much sense to have them separately enabled/disabled if the dependencies are not handled automatically.

comment:4 Changed 15 months ago by matt (mattab)

  • Priority changed from normal to critical

This was reported also in #3737

comment:5 Changed 15 months ago by Zverik

I disabled Overlay plugin, and after a force reload it works ok. Thanks for the tip.

But why Overlay plugin is suddenly enabled? I don't want it and didn't know piwik adds and enables plugins during updates. Now I have to browse plugin list and disable other plugins that appeared since I first installed piwik.

comment:6 Changed 15 months ago by matt (mattab)

Good point, we also could write a message in the Update screen, with the list of newly enabled plugins.

comment:7 Changed 13 months ago by matt (mattab)

In 3f35263010e91b4dc434184b67c2e42c46476d9c:

Refs #3701 adding simple message in UI

comment:8 Changed 13 months ago by capedfuzz (diosmosis)

  • Owner set to diosmosis
  • Resolution set to fixed
  • Status changed from new to closed

In 19e35c0167bcfcae53d95191828795d47789c523:

Fixes #3701, check whether transitions plugin is loaded before showing overlay icon in datatable.

comment:9 Changed 11 months ago by matt (mattab)

  • Priority changed from critical to normal
Note: See TracTickets for help on using tickets.