Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display browser language of the visitors #3726

Closed
sgiehl opened this issue Feb 3, 2013 · 15 comments
Closed

Display browser language of the visitors #3726

sgiehl opened this issue Feb 3, 2013 · 15 comments
Assignees
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@sgiehl
Copy link
Member

sgiehl commented Feb 3, 2013

Browser language setting is already tracked for every visitor.
That data should also be available within the frontend.

@halfdan
Copy link
Member

halfdan commented Feb 4, 2013

I agree that this is interesting. Right now though, we don't even store the data in the 1st normal form (e.g. de-de,de,en-us,en).

Sometimes we have multiple occurences of the same language, e.g. de-de,de,en-us,en - which one is important here? de-de or de? Are they the same? What about en, en-gb and en-us?

What is important here? Should we just count the first language or all in the list? Should we build multiple statistics like "First Browser Language", "Second Browser Language"?

Ideas?

@sgiehl
Copy link
Member Author

sgiehl commented Feb 4, 2013

I guess the main language should be enough for most users.
Btw. I'm already on that. Guess I'll finish that by the end of the week...

@halfdan
Copy link
Member

halfdan commented Feb 4, 2013

Ah nice! Good to know, almost started with it myself :)

@mattab
Copy link
Member

mattab commented Feb 4, 2013

Only first language of the list, to keep things simple I think.

We could alternatively look at secondary languages if the first one is en-us for example, because I know lots of browsers ship by default with en-us settings and users don't necessarily change it.

@sgiehl
Copy link
Member Author

sgiehl commented Feb 10, 2013

In 3f49038: refs #3726 adding reports for browser language of visitors

@sgiehl
Copy link
Member Author

sgiehl commented Feb 10, 2013

In d1546c5: refs #3726 small test for method to get language from browser setting

@sgiehl
Copy link
Member Author

sgiehl commented Feb 10, 2013

In abce17a: refs #3726 fixing test

@sgiehl
Copy link
Member Author

sgiehl commented Feb 10, 2013

In b2aeb6a: refs #3726 added language names to translations

@sgiehl
Copy link
Member Author

sgiehl commented Feb 10, 2013

In 74ff8ea: refs #3726 small improvements to detection method

@sgiehl
Copy link
Member Author

sgiehl commented Feb 10, 2013

In e29d059: refs #3726 fixing some integration tests

@halfdan
Copy link
Member

halfdan commented Feb 10, 2013

Thanks! :-) I was scratching my head for the last 5 minutes and wondered why tests were suddenly failing on Travis..

@sgiehl
Copy link
Member Author

sgiehl commented Feb 10, 2013

In 952dbcd: refs #3726 fixing integration test files

@mattab
Copy link
Member

mattab commented Feb 11, 2013

Very nice changes!

Code review:

  • Some of the new code in: Piwik_UserSettings::_getLanguageCodeFromBrowserSetting
    is redundant with existing code in: Piwik_Common::extractCountryCodeFromBrowserLanguage
    I think both should use same logic ?

@mattab
Copy link
Member

mattab commented Feb 11, 2013

In 2826710: small refactor refs #3726

@sgiehl
Copy link
Member Author

sgiehl commented Feb 12, 2013

In 09bdded: fixes #3726 use Piwik_Common::extractLanguageCodeFromBrowserLanguage instead of new method to get language code

@sgiehl sgiehl added this to the 1.11 - Piwik 1.11 milestone Jul 8, 2014
@sgiehl sgiehl self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

3 participants