New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Performance: Fix memory leak during Archiving process #5794
Comments
[this topic](watching) |
fixed in 0.2.26 |
I am sorry, but I have still some problems. Generating grafics for Month doesn’t work. Generating grafics and calculation numbers for Year doesn’t work. And in visitors>overview I get: Fatal error: Allowed memory size of 67108864 bytes exhausted (tried to allocate 71 bytes) in /var/www/web5/html/piwik/core/DataTable.php on line 822 |
Is this still occuring in 0.2.28? |
Glad you ask. I have no errors within Month and year views anymore. (But I also have 64MB php memory now) However, Piwik is still not able to display the sparklines and the grafics “last visitors” and “returnig visitors”. I think it could be some kind of timeout. |
Firefox’s Error Console reports: Warning: 09 is not a legal ECMA-262 octal constant |
In plugins/CoreHome/templates/js_global_variables.tpl, change these lines: ``` to: ``` |
Thanks for the help!!! I changed the line, but the error was still there. Then I changed it to: ``` Now the error is gone, but I have still no flash chart with the last visitors :-( Anyway it looks like this is problem is not connected with the memory leak? |
This is the error from the data URL from your Last visits graph and Visitors Evolution graph (day=yesterday, period=month): Fatal error: Allowed memory size of 67108864 bytes exhausted (tried to allocate 72 bytes) in /var/www/web5/html/piwik/core/DataTable.php on line 836 Matt? |
vipsoft, what happens is that, for a given website, we store all data in memory (in ArchiveProcessing_Record_*), and at the end of processing all the processed statistics for a given website, we store all this data in DB. What we could do is: Downside is that we would not have this data anymore, if other plugins want to access data that has just been processed by other plugins, to enrich/change it, for example. However this use case is not yet found in Piwik code, so we could assume it is a change we can make. What would be changed in Piwik_ArchiveProcessing_Record_Manager: |
konus, vipsoft, committed octal-javascript bug in 898 |
Hello, I’ve also got this problem, and I had to re-install Piwik. I do not think that is a good option, I do think I will get the same problem again when the archive is big enough. Is there any work-around for this issue? |
(In 987) – refs #5794 test post commit |
(In 1035) – memory and speed optimizations of archiving, refs #5794 (hopefully fixing it but not sure yet) |
fixed! apparently bug has been fixed in php 5.3 so we shall see if php is dealing better with deleting old objects with cross references. the memory leak problem is GONE! we were able to process stats of piwik.org for the last few months and year without any problem for 100k+ unique visitors |
Thank you very much! I am happy to report, that piwik is now reporting within month and year timeframe. |
Hi guys, any help please? Cheers. |
macada: there is a fix in Piwik that avoids this particular memory leak situation, and does not require php 5.3. If you are still encountering a problem with archiving, please open a new ticket and provide detailed information. |
The new ticket is #685 |
This ticket was reopened in #766 |
The following php memory error is showing up when there is too much data.
``
There are improvements to be made in the archiving process to make it more memory / computation efficient.
``````
The text was updated successfully, but these errors were encountered: