Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ImageGraph BackgroundColor / TextColor customizable #3799

Closed
tsteur opened this issue Mar 5, 2013 · 25 comments
Closed

Make ImageGraph BackgroundColor / TextColor customizable #3799

tsteur opened this issue Mar 5, 2013 · 25 comments
Assignees
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Mar 5, 2013

Make backgroundColor, textColor and axisColor of a graph customizable via URL parameters.

This is interesting for new mobile app.

@mattab
Copy link
Member

mattab commented Mar 11, 2013

New mobile app with pretty graphs FTW

@tsteur
Copy link
Member Author

tsteur commented Apr 7, 2013

Attachment:
piwikgraph.png

@tsteur
Copy link
Member Author

tsteur commented Apr 7, 2013

Graph does not have to look like the attachment but would be great to be able to set backgroundColor, textColor and axisColor to those colors via URL parameter.

@julienm do you think you'll find some time to implement this in the next 4-6 weeks? Otherwise I'll maybe have a look at it

@julienmoumne
Copy link
Member

Yes I can have a look at it.

Could you give me examples of colors for each parameter?

Also, will you need to specify transparency for the background (and eventually for the other parameters) ?

@julienmoumne
Copy link
Member

Also, should it be possible to set the legend font color differently from the axes values font color?

@julienmoumne
Copy link
Member

I have committed in my repo three new ImageGraph API parameters $textColor, $backgroundColor and $gridColor : https://github.com/JulienMoumne/piwik/commit/cd811234e4b838f651ef0ef5d1218175e19d204d

If you can, do tell me if this is what you are looking for.

@tsteur
Copy link
Member Author

tsteur commented Apr 7, 2013

sure!

backgroundColor = #efefef
axisColor or gridColor = #dcdcdc
legendColor = #000000
labelColor = #000000
lineColor = #cb2026

I don't need to be able to change the different line colors of the evolution graph.

@tsteur
Copy link
Member Author

tsteur commented Apr 7, 2013

oh cool! Thx for working on that so fast. I will test it tomorrow.

@julienmoumne
Copy link
Member

From what I see you may need more granularity than what I implemented. Do tell me after testing if this is the case.

@tsteur
Copy link
Member Author

tsteur commented Apr 8, 2013

Looks good so far! Aweseome! See attachment piwikGraph_1.png. The only missing thing I need in addition is to be able to change the color of a line / bar (which is currently blue by default). I need to set it to "#cb2026". I need to change it only for static graphs, not for evolution graphs where 5 or 6 different colors are used.

@tsteur
Copy link
Member Author

tsteur commented Apr 8, 2013

Attachment:
piwikGraph_1.png

@julienmoumne
Copy link
Member

To change the color of the line and/or bars, try to use &colors=FF00FF on my branch commit.

@tsteur
Copy link
Member Author

tsteur commented Apr 8, 2013

Works perfect! You made my day! Thanks!

BTW: Not sure if it is related: When using this url to generate the graph:

http://apache.piwik/index.php?module=API&method=ImageGraph.get&idSite=1&apiModule=Referers&apiAction=getAll&period=day&date=2013-04-05,2013-04-07&filter_sort_column=nb_visits&column=nb_visits&columns=nb_visits&language=en&width=300&height=150&fontSize=9&showMetricTitle=0&aliasedGraph=1&legendAppendMetric=0&backgroundColor=efefef&gridColor=dcdcdc&colors=cb2026&showLegend=0

I'm getting this error which seems to only occur when graph is an evolution graph:

Warning: array_merge(): Argument #2 is not an array in /var/www/piwik/plugins/ImageGraph/StaticGraph.php on line 268 

Backtrace -->

#0 Piwik_ErrorHandler(...) called at [:]
#1 array_merge(...) called at [/var/www/piwik/plugins/ImageGraph/StaticGraph.php:268]
#2 Piwik_ImageGraph_StaticGraph->initpImage(...) called at [/var/www/piwik/plugins/ImageGraph/StaticGraph.php:279]
#3 Piwik_ImageGraph_StaticGraph->getTextWidthHeight(...) called at [/var/www/piwik/plugins/ImageGraph/StaticGraph/Exception.php:55]
#4 Piwik_ImageGraph_StaticGraph_Exception->renderGraph(...) called at [/var/www/piwik/plugins/ImageGraph/API.php:486]
#5 Piwik_ImageGraph_API->get(...) called at [:]
#6 call_user_func_array(...) called at [/var/www/piwik/core/API/Proxy.php:187]
#7 Piwik_API_Proxy->call(...) called at [/var/www/piwik/core/API/Request.php:138]
#8 Piwik_API_Request->process(...) called at [/var/www/piwik/plugins/API/Controller.php:25]
#9 Piwik_API_Controller->index(...) called at [:]
#10 call_user_func_array(...) called at [/var/www/piwik/core/FrontController.php:125]
#11 Piwik_FrontController->dispatch(...) called at [/var/www/piwik/index.php:47]

Link to that file:
https://github.com/JulienMoumne/piwik/blob/cd811234e4b838f651ef0ef5d1218175e19d204d/plugins/ImageGraph/StaticGraph.php

@julienmoumne
Copy link
Member

Try this https://github.com/JulienMoumne/piwik/commit/d189d5a29a3b4fd4f938bd180fee7aa72e8c5cce

You will still have an exception but this time it will be more explicit.

@tsteur
Copy link
Member Author

tsteur commented Apr 8, 2013

Seems to be fixed. The following error message is displayed within the graph now:

API returned an error. Refererrs.getAll with multiple sites or dates is not supported (yet).

But that's another issue which has nothing to do with the colors (API should not return an evolution graph url for this report). Refererrs.getRefererType works fine.

@julienmoumne
Copy link
Member

It seems there is an issue with metadata indeed. Could you create a separate ticket for the metadata issue?

Concerning the current ticket, could you confirm you have all you needed and that we can commit and close the ticket?

@tsteur
Copy link
Member Author

tsteur commented Apr 9, 2013

I can confirm I have all I needed. Thx again!

Will open a separate ticket for the other metadata issue.

@anonymous-matomo-user
Copy link

In cd81123: refs #3799 new ImageGraph API parameters $textColor, $backgroundColor and $gridColor (missing updated expected integration files)

@anonymous-matomo-user
Copy link

In d189d5a: refs #3799 new parameter $textColor is required to render exceptions

@anonymous-matomo-user
Copy link

In a57ca6a: fixes #3799 update expected integration files

every text is now of the same color
legend text color was and remains 222222
axes figures was 000000 and becomes 222222

@mattab
Copy link
Member

mattab commented Apr 10, 2013

excellent, I can't wait to see the new graphs that result of this ;-)

@tsteur
Copy link
Member Author

tsteur commented Apr 20, 2013

@anonymous-matomo-user
Copy link

In 25a5ac6: fixes #3799 apply colors to exception message

@tsteur
Copy link
Member Author

tsteur commented Apr 20, 2013

thx!

@tsteur tsteur added this to the 2.x - The Great Piwik 2.x Backlog milestone Jul 8, 2014
@Dturner2
Copy link

huh

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

5 participants