Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include encoding in .svg header #3809

Closed
robocoder opened this issue Mar 10, 2013 · 3 comments
Closed

Include encoding in .svg header #3809

robocoder opened this issue Mar 10, 2013 · 3 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@robocoder
Copy link
Contributor

The fix in [7873deb] doesn't entirely resolve the issue with .svg files not being served correctly.

On older Apache servers, there is no mime-type defined for svg+xml.

On Ubuntu 12.04, the Apache server's "magic" file expects the header to conform to:

0   string      \<?xml
>38 string      \<\!DOCTYPE\040svg  image/svg+xml

This ticket is to update all .svg files to have the following header:

<?xml version="1.0" encoding="UTF-8"?><!DOCTYPE svg  PUBLIC '-//W3C//DTD SVG 1.1//EN'  'http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd'>

Currently, the UserCountry .svg files have:

<?xml version="1.0" ?><!DOCTYPE svg  PUBLIC '-//W3C//DTD SVG 1.1//EN'  'http://www.w3.org/Graphics/SVG/1.1/DTD/svg11.dtd'>

while logo.svg has no header.

@robocoder
Copy link
Contributor Author

In 266da1c: fixes #3809 - add encoding to .svg files

@robocoder
Copy link
Contributor Author

In 9290d17: refs #3809 - remove magic file

@mattab
Copy link
Member

mattab commented Mar 11, 2013

I didn't notice it before, nice fix.

@robocoder robocoder added this to the 1.12 - The Great 1.x Backlog milestone Jul 8, 2014
@robocoder robocoder self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants