Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socials Widget fails to display icons when report is flattened #3827

Closed
halfdan opened this issue Mar 14, 2013 · 6 comments
Closed

Socials Widget fails to display icons when report is flattened #3827

halfdan opened this issue Mar 14, 2013 · 6 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
1.12

Comments

@halfdan
Copy link
Member

halfdan commented Mar 14, 2013

The Socials widget fails to display social icons when report is flattened.

http://demo.piwik.org/index.php?filter_column=label&filter_column_recursive=label&idGoal=-1&filter_sort_order=desc&keep_summary_row=0&filter_limit=10&viewDataTable=table&module=Referers&action=getSocials&idSite=7&period=year&date=2013-03-09&controllerActionCalledWhenRequestSubTable=getUrlsForSocial&enable_sort=1&totalRows=7&include_aggregate_rows=1&filter_sort_column=nb_visits&flat=1

Instead of the correct icon, the URL points to xx.png which isn't available. This does not happen for all URLs.
@pebosi
Copy link
Contributor

pebosi commented Apr 8, 2013

Another bug with this. If you make the table flat, no pager is shown and the row count does not update.

@pebosi
Copy link
Contributor

pebosi commented Apr 8, 2013

Attachment:
Selection_001.png

@sgiehl
Copy link
Member

sgiehl commented Apr 15, 2013

In 9ea00b7: refs #3827 fixes incorrect icons. url needs to be cleaned for icons in flat mode

@sgiehl
Copy link
Member

sgiehl commented Apr 15, 2013

@pebosi: I can't reproduce your bug. Can you reproduce that on the piwik demo, aswell?

@pebosi
Copy link
Contributor

pebosi commented Apr 16, 2013

I think this commit fixed it: 5a8074a

@sgiehl
Copy link
Member

sgiehl commented Apr 16, 2013

Ok. fine

@halfdan halfdan added this to the 1.12 - The Great 1.x Backlog milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
3 participants
@halfdan @pebosi @sgiehl