Opened 13 months ago

Closed 13 months ago

Last modified 13 months ago

#3833 closed Bug (fixed)

Archiving custom range is not triggered correctly.

Reported by: p.banaszczyk Owned by: mattab
Priority: normal Milestone: 1.12 - The Great 1.x Backlog
Component: Core Keywords: range, custom period, browser trigger
Cc: Sensitive: no

Description

Seems that custom period should is only metric that should be processed independently (regardless browser triggering is on/off)

In global.ini.php we can disable browser archiving for everything except custom period, what seems to be expected behavior (as custom period needs to be archived somehow)

The only time that the browser will still trigger archiving is when requesting a custom date range that is not pre-processed yet

In current version (1.10 and 1.11 - not sure how it worked earlier) after disabling browser archiving (high traffic page - we're using archive scripts to compute data) i had problems with getting correct results for periods

[2013-03-15 15:29:38] [35d4e34d] [13.66 Mb] * ARCHIVING DISABLED, for Preparing archive: range(From 2013-03-12 to 2013-03-13), plugin VisitsSummary , Visits = <br/>

what shouldn't happen for period range.

In attachment patch that should solved this issue.

Attachments (1)

archivingPatch.diff (793 bytes) - added by p.banaszczyk 13 months ago.
Piwik_ArchiveProcessing range fix

Download all attachments as: .zip

Change History (4)

Changed 13 months ago by p.banaszczyk

Piwik_ArchiveProcessing range fix

comment:1 Changed 13 months ago by mauser (zawadzinski)

We shall use $this->periodId to check which period we are dealing with (the request var may not be set)

comment:2 Changed 13 months ago by matt (mattab)

  • Owner set to mattab
  • Resolution set to fixed
  • Status changed from new to closed

In 03a6e97eef6b1a0d1b6909685624eae4b98eec56:

Fixes #3833 adding check upstream. Thx for the report & patch, very nice bug to fix!

comment:3 Changed 13 months ago by peterb (peterbo)

In 5700b3702b03a11000a381815460f35907087610:

Refs #3833 - Piwik_Period's toString method does not return the type of the Period and a "Array to String conversion" notice is triggered. So we use the getLabel accessor.

Note: See TracTickets for help on using tickets.