Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Archiving custom range is not triggered correctly. #3833

Closed
anonymous-matomo-user opened this issue Mar 15, 2013 · 4 comments
Closed

Archiving custom range is not triggered correctly. #3833

anonymous-matomo-user opened this issue Mar 15, 2013 · 4 comments
Assignees
@mattab
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
1.12

Comments

@anonymous-matomo-user
Copy link

Seems that custom period should is only metric that should be processed independently (regardless browser triggering is on/off)

In global.ini.php we can disable browser archiving for everything except custom period, what seems to be expected behavior (as custom period needs to be archived somehow)

The only time that the browser will still trigger archiving is when requesting a custom date range that is not pre-processed yet

In current version (1.10 and 1.11 - not sure how it worked earlier) after disabling browser archiving (high traffic page - we're using archive scripts to compute data) i had problems with getting correct results for periods

[2013-03-15 15:29:38] [35d4e34d] [13.66 Mb] * ARCHIVING DISABLED, for Preparing archive: range(From 2013-03-12 to 2013-03-13), plugin VisitsSummary , Visits = <br/>

what shouldn't happen for period range.

In attachment patch that should solved this issue.

Keywords: range, custom period, browser trigger
@anonymous-matomo-user
Copy link
Author

Attachment: Piwik_ArchiveProcessing range fix
archivingPatch.diff

@zawadzinski
Copy link
Contributor

We shall use $this->periodId to check which period we are dealing with (the request var may not be set)

@mattab
Copy link
Member

mattab commented Mar 17, 2013

In 03a6e97: Fixes #3833 adding check upstream. Thx for the report & patch, very nice bug to fix!

@peterbo
Copy link
Contributor

peterbo commented Mar 18, 2013

In 5700b37: Refs #3833 - Piwik_Period's toString method does not return the type of the Period and a "Array to String conversion" notice is triggered. So we use the getLabel accessor.

@anonymous-matomo-user anonymous-matomo-user added this to the 1.12 - The Great 1.x Backlog milestone Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
4 participants
@mattab @peterbo @zawadzinski @anonymous-matomo-user