Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evolution ImageGraph is not working for Referers.getAll #3887

Closed
tsteur opened this issue Apr 9, 2013 · 6 comments
Closed

Evolution ImageGraph is not working for Referers.getAll #3887

tsteur opened this issue Apr 9, 2013 · 6 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@tsteur
Copy link
Member

tsteur commented Apr 9, 2013

When opening the Referers.getAll evolution graph I'm getting the following error message:

API returned an error. Referers.getAll with multiple sites or dates is not supported (yet).

Link to reproduce:
http://demo.piwik.org/?module=API&method=ImageGraph.get&idSite=7&period=day&date=last7&apiModule=Referers&apiAction=getAll&outputType=0&showLegend=1&fontSize=9&aliasedGraph=1&legendAppendMetric=1&format=JSON&token_auth=anonymous

Link to file:
https://github.com/piwik/piwik/blob/master/plugins/Referers/API.php#L113

To fix this issue, Referrers.getAll should either support multiple dates/websites or MetadataAPI should not return an imageGraphEvolutionUrl for this report, see:

http://demo.piwik.org/?module=API&method=API.getProcessedReport&idSite=7&period=day&date=today&apiModule=Referers&apiAction=getAll&showTimer=1&format=JSON&token_auth=anonymous

@mattab
Copy link
Member

mattab commented Apr 20, 2013

+1 for "MetadataAPI should not return an imageGraphEvolutionUrl for this report"

@mattab
Copy link
Member

mattab commented May 23, 2013

In 2d5b0ac: Fixes #3887
Hiding row evolution graph URL from output for Referrer.getAll
Please double test it's all working!

@julienmoumne
Copy link
Member

I am not sure this is right.

'constantRowsCount' = 1 means there are a constant number of rows, ie. Piwik websites.

This is not true.

I suggest the imageGraphEvolutionUrl metadata entry be left empty in http://git.piwik.org/piwik.git/blob/master/plugins/ImageGraph/ImageGraph.php#L46 by using a static list of excluded reports.

@julienmoumne
Copy link
Member

This explains why you had to update an image in an integration testing file :2d5b0ac#diff-1

This image should not have changed since it is not an evolution graph.

@mattab
Copy link
Member

mattab commented May 26, 2013

In 70b46ec: Fixes #3887
Proper fix for this problem, adding static array of "Row evolution not supported"

Also I decided to enable tests so they all run on my box /standard ubuntu, rather than travis CI.
Fixed a bug in tests that plugins language files were not loaded early enough.

@mattab
Copy link
Member

mattab commented May 26, 2013

Of course you were right Julien +1

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants