Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Piwik PHP source code to PSR coding standard #3895

Closed
mattab opened this issue Apr 14, 2013 · 1 comment
Closed

Update Piwik PHP source code to PSR coding standard #3895

mattab opened this issue Apr 14, 2013 · 1 comment
Assignees
@mattab
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
1.12

Comments

@mattab
Copy link
Member

mattab commented Apr 14, 2013

Piwik is updating the Coding standards to use PSR php coding style convention.

We used Phpstorm to convert all code automatically to the new standards.

The coding style XML file for Phpstorm will be published here.

Note: I will re-run the conversion in a few weeks after PHP 5.3 conversion.

The new code makes sure the code looks nice and consistent across all files. As the number of developers grew, this change was important!
@mattab
Copy link
Member Author

mattab commented Apr 14, 2013

In 1c41d3c: Publishing the Phpstorm custom PSR coding style for others to reuse (and to make sure I don't lose it, since we want to apply it again (eg. every year or so))

This fixes #3895

the mass conversion was applied in: [ae4b031]

@mattab mattab added this to the 1.12 - The Great 1.x Backlog milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
1 participant
@mattab