Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin Overlay does not support squared brackets [] #3929

Closed
mbresch-sf opened this issue May 7, 2013 · 4 comments
Closed

Plugin Overlay does not support squared brackets [] #3929

mbresch-sf opened this issue May 7, 2013 · 4 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@mbresch-sf
Copy link

TYPO3 uses %5B and %5D instead of [ and ] in internal links. In pages and transition piwik translate %5B and %5D fine. But in overlays this substitution does not exist.

In urlnormalizer.js at line 194 I add the following two lines of code which solves the problem for me. But I am not familiar with piwik development so please check this is the right way to fix this issue.

url = url.replace(/%5B/gi, '[');
url = url.replace(/%5D/gi, ']');

@mattab
Copy link
Member

mattab commented May 14, 2013

Thanks for the report!

@mattab
Copy link
Member

mattab commented Feb 6, 2014

@mbresch are you still using this patch, and is it fixing the Overlay issue for you in Piwik 2?

@mbresch-sf
Copy link
Author

Hi Matt,
sorry for my late reply!

This patch is working in Piwik 2.0.3 pretty well!!! I still using this patch and it is working for me. Yes

Greetings
Marco

@mattab
Copy link
Member

mattab commented Apr 27, 2014

Moving bugs to our current milestone to make the backlog more realistic.

@mbresch-sf mbresch-sf added this to the 2.5.0 - Piwik 2.5.0 milestone Jul 8, 2014
@mattab mattab modified the milestones: Mid term, Short term Apr 9, 2015
@mattab mattab closed this as completed in b45e595 Apr 9, 2015
@mattab mattab modified the milestones: Piwik 2.13.0, Mid term Apr 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

2 participants