Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User Country Map - Incorrect calculated height of world map in iframe #3935

Closed
anonymous-matomo-user opened this issue May 13, 2013 · 3 comments
Closed

User Country Map - Incorrect calculated height of world map in iframe #3935

anonymous-matomo-user opened this issue May 13, 2013 · 3 comments
Assignees
@mattab
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
1.12

Comments

@anonymous-matomo-user
Copy link

I encountered a bug of incorrect calculated height of world map when integrating User Country Map widget in my site via iframe.

Please see the reproduction at http://jsfiddle.net/JcQmQ/. The widget is clipped by its containing iframe in the bottom.

Further investigation, i found that resize function in vistor-map.js that calculates dimension of map incorrectly.

var ratio, w, h,
map = this.map,
maxHeight = $(window).height() - (this.theWidget && this.theWidget.isMaximised ? 150 : 55);

In case of using iframe, the height of map is equals to iframe's height subtracted by 55px. But observing actual height of this widget, it should be subtracted by 79px.

Hope this help!

Keywords: UserCountryMap
@mattab
Copy link
Member

mattab commented May 14, 2013

thanks for report. Do you suggest we replace 55 by 79 in this code? I could do this, please confirm.

@anonymous-matomo-user
Copy link
Author

Yes, please. Thanks for your supports.

thanks for report. Do you suggest we replace 55 by 79 in this code? I could do this, please confirm.

@mattab
Copy link
Member

mattab commented May 14, 2013

In 23500db: Fixes #3935 Thanks for the patch!

@anonymous-matomo-user anonymous-matomo-user added this to the 1.12 - The Great 1.x Backlog milestone Jul 8, 2014
This was referenced Apr 23, 2022
Open
Open
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
2 participants
@mattab @anonymous-matomo-user