#3957 closed Bug (fixed)

window_look_back_for_visitor break js visit length

Reported by: mahdi Owned by: mattab
Priority: major Milestone:
Component: Core Keywords:
Cc: Sensitive: no

Description

hi there,

I have combined instance of piwik with both js tracked sites and log imported sites.

I have set window_look_back_for_visitor = 2678400 so I can track log imported returning visitors, no problem with this it works fine and doesn't cause any performance problem even for such long period.

However it breaks js tracked sites see attached screenshot

  • first record on the screenshot is with entirely disabled window_look_back_for_visitor and is perfectly correct
  • other lines are with window_look_back_for_visitor enabled and as you can see wrong

using 1.11.1 - is this something to be fixed in 1.12? I cannot run this on production right now.

Attachments (1)

visitor_log.png (54.2 KB) - added by mahdi 11 months ago.

Download all attachments as: .zip

Change History (4)

Changed 11 months ago by mahdi

comment:1 Changed 11 months ago by matt (mattab)

In fa36f400879eee408a79b6a45443fbec0a48b14a:

Adding failing test case showing the bug (visit over several days, creates too many visits) refs #3957

comment:2 Changed 11 months ago by matt (mattab)

In 9e16d35862ae79c9b006a43193fccdb67e60d89a:

This fixture says "14 visits" which is the bug: it should say only "10" visits Refs #3957

comment:3 Changed 11 months ago by matt (mattab)

  • Owner set to mattab
  • Resolution set to fixed
  • Status changed from new to closed

In 4f2628fca49047af472f9725b2589392ec3292a7:

Fixes #3957 thanks for the report and nice find! The bug was the missing ORDER clause.

Also fixing the "look ahead code" to lookahead at most the visit standard length

Note: See TracTickets for help on using tickets.