Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the /.git test in the System Check file integrity #4047

Closed
oerdnj opened this issue Jul 11, 2013 · 3 comments
Closed

Remove the /.git test in the System Check file integrity #4047

oerdnj opened this issue Jul 11, 2013 · 3 comments
Assignees
@mattab
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.0

Comments

@oerdnj
Copy link

oerdnj commented Jul 11, 2013

Some people like to maintain the websites in the local git (for easy modifications, etc.), and it would be nice to have the ability to disable (in config.ini.php) this check:

--- Piwik.php   2013-06-25 08:22:23.054989006 +0200
+++ /git/piwik/core/Piwik.php   2013-05-30 10:57:06.000000000 +0200
@@ -625,10 +625,10 @@ class Piwik
         $messages[] = true;

         // ignore dev environments
-        // if (file_exists(PIWIK_INCLUDE_PATH . '/.git')) {
-        //    $messages[] = Piwik_Translate('General_WarningFileIntegritySkipped');
-        //    return $messages;
-        // }
+        if (file_exists(PIWIK_INCLUDE_PATH . '/.git')) {
+            $messages[] = Piwik_Translate('General_WarningFileIntegritySkipped');
+            return $messages;
+        }

         $manifest = PIWIK_INCLUDE_PATH . '/config/manifest.inc.php';
         if (!file_exists($manifest)) {

So I don't have to patch my instance (which in turn cries in the System Check that the files have been modified).

Thanks.
@mattab
Copy link
Member

mattab commented Jul 16, 2013

.

@mattab
Copy link
Member

mattab commented Jul 16, 2013

In 938271a: Fixes #4047 Just removing the test as it is actually not useful anymore (the manifest.inc.php test that follows is doing the job). thanks for the report!

@mattab
Copy link
Member

mattab commented Jul 17, 2013

In 89a6a78: Refs #4047 Also removing the now unused translation (and removed from otrance)

@oerdnj oerdnj added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Fixes matomo-org#4047 Just removing the test as it is actually not us…
938271a 
…eful anymore (the manifest.inc.php test that follows is doing the job). thanks for the report!
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4047 Also removing the now unused translation (and re…
89a6a78 
…moved from otrance)
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@oerdnj @mattab