Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Piwik classes (core + plugins) to use PHP Namespaces #4059

Closed
mattab opened this issue Jul 21, 2013 · 7 comments
Closed

Convert Piwik classes (core + plugins) to use PHP Namespaces #4059

mattab opened this issue Jul 21, 2013 · 7 comments
Assignees
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Jul 21, 2013

As discussed in #3741, Piwik 2 will make use of the namespace feature of PHP 5.3. This implementation of best practises of modern PHP will lead to more readable code and overall better Piwik platform for developers.

@mattab
Copy link
Member Author

mattab commented Jul 23, 2013

In aca8ec3: Refs #4059 Work in progress: Conversion to use Namespaces: Period*, Metrics, Segment, SegmentExpression, PluginsManager.
Removed some deprecated code.

@mattab
Copy link
Member Author

mattab commented Jul 23, 2013

In ae4b1f4: Refs #4059 Work in progress: Conversion to use Namespaces

@mattab
Copy link
Member Author

mattab commented Jul 23, 2013

In 5104d94: Refs #4059 Work in progress: Conversion to use Namespaces of dozen more classes
Removed many Piwik_ functions, in Piwik 2 it is best practise to use the methods calls instead

Todo: finish converting core/ classes + convert plugins/ classes to use \Piwik\Plugin namespace + fix build + Merge master

@mattab
Copy link
Member Author

mattab commented Jul 31, 2013

Remaining Tasks for a beautiful namespaced Piwik:

  • Simplify auto loader (reuse this)
  • Convert plugins/ to use \Piwik\Plugin namespace
  • Search for Piwik_ in source code and fix them all
  • remove unprefixClass
  • Convert tests/ to use \Piwik\Tests
  • ...?

@mattab
Copy link
Member Author

mattab commented Aug 2, 2013

In a96ec40: Refs #4059 Converting dozens of plugins/* classes to use Namespaces, \Piwik\Plugins*
Added namespaces to functions.php files in the five plugins that had one
Work in progress

@mattab
Copy link
Member Author

mattab commented Aug 11, 2013

see follow up #4074

@mattab
Copy link
Member Author

mattab commented Oct 8, 2013

In b738433: Refs #4059 Converting updates files to use namespaces

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…Period*, Metrics, Segment, SegmentExpression, PluginsManager.

Removed some deprecated code.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…f dozen more classes

Removed many Piwik_ functions, in Piwik 2 it is best practise to use the methods calls instead

Todo: finish converting core/ classes + convert plugins/ classes to use \Piwik\Plugin namespace + fix build + Merge master
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…mespaces, \Piwik\Plugins\*

Added namespaces to functions.php files in the five plugins that had one
Work in progress
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

1 participant