Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API CHANGE: Plugin Referers now called Referrers #4125

Closed
mattab opened this issue Sep 6, 2013 · 15 comments
Closed

API CHANGE: Plugin Referers now called Referrers #4125

mattab opened this issue Sep 6, 2013 · 15 comments
Assignees
Labels
Critical Indicates the severity of an issue is very critical and the issue has a very high priority. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. worksforme The issue cannot be reproduced and things work as intended.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Sep 6, 2013

Let's use the Piwik 2.0 release opportunity to rename some badly named plugins:

  • PDFReports becomes ScheduledReports
  • Referers becomes Referrers
@sgiehl
Copy link
Member

sgiehl commented Oct 1, 2013

I've already renamed all translation keys accordingly.

@anonymous-matomo-user
Copy link

In 1b2cf69: Refs #4125, add test case that makes sure blobs w/ Referers_ prefix are used if found.

@anonymous-matomo-user
Copy link

In cefbc7f: Refs #4125, make Referers_... blob test less useless and move out of OneVisitorTwoVisitsTest.

@anonymous-matomo-user
Copy link

In 0deb2bb: Refs #4125, rename Referers_... record names to Referrers and make sure code is backwards compatible.

@mattab
Copy link
Member Author

mattab commented Oct 7, 2013

I vote for revert this change and instead:

  • rename all archive records from Referers to Referrers using Mysql REPLACE string function
  • This way data is consistent in the DB and we dont need to add the complex BC handler code

@mattab
Copy link
Member Author

mattab commented Oct 7, 2013

In a27771e: Refs #4125 Renaming plugin from Referers to Referrers

  • updating all variables/methods containing Referers
  • RENAMING custom segments definition, and custom scheduled reports definition, so that when they load "Referers" segment/report it still works as expected
  • RENAMING old archived data so that archived blobs are called Referrers
    • Reverting part of 0deb2bb
    • Update integration tests generating PDF+HTML with images on my dev box (GD 2.1 and PHP 5.5)

@mattab
Copy link
Member Author

mattab commented Oct 7, 2013

In 9e4842e: Refs #4125 Checking we still read old config values for truncation

@mattab
Copy link
Member Author

mattab commented Oct 7, 2013

In 9ca63b0: Refs #4125 Renaming PDFReports to ScheduledReports

@mattab
Copy link
Member Author

mattab commented Oct 7, 2013

In 4d3527c: Refs #4125 commit SQL Update file

@mattab
Copy link
Member Author

mattab commented Oct 7, 2013

In e4f1bdd: Refs #4125 Fixes

@mattab
Copy link
Member Author

mattab commented Oct 7, 2013

In b03211c: Refs #4125 renaming expected files

@mattab
Copy link
Member Author

mattab commented Oct 7, 2013

In 64a7597: Refs #4125 adding backtick so it works if there is no prefix (where option is a mysql reserved keyword)

@mattab
Copy link
Member Author

mattab commented Oct 16, 2013

In eeb705a: Making sure API calls using old Referers or PDFReports would still work by automatically loading the new plugin instead (kind of internal Redirects) refs #4125 #4219

@anonymous-matomo-user
Copy link

This doesn't work. If you call "Referers" on API Version > 2.0.0 you get an error message. If you call the new word on old APIs you get an error message, too.

I fixed it for myself with checking the API version, but maybe this helps another people.

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…nd make sure code is backwards compatible.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
 * updating all variables/methods containing Referers
 * RENAMING custom segments definition, and custom scheduled reports definition, so that when they load "Referers" segment/report it still works as expected
 * RENAMING old archived data so that archived blobs are called Referrers
  * Reverting part of 0deb2bb
  * Update integration tests generating PDF+HTML with images on my dev box (GD 2.1 and PHP 5.5)
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…x (where `option` is a mysql reserved keyword)
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…rk by automatically loading the new plugin instead (kind of internal Redirects) refs matomo-org#4125 matomo-org#4219
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Critical Indicates the severity of an issue is very critical and the issue has a very high priority. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change. worksforme The issue cannot be reproduced and things work as intended.
Projects
None yet
Development

No branches or pull requests

3 participants