Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly handle bulk tracking #4135

Closed
halfdan opened this issue Sep 6, 2013 · 2 comments
Closed

Properly handle bulk tracking #4135

halfdan opened this issue Sep 6, 2013 · 2 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github.
Milestone

Comments

@halfdan
Copy link
Member

halfdan commented Sep 6, 2013

There are some flaws in the current way bulk tracking is handled:

Code:

Sent to security@.

Documentation:
The documentation only shows only one way to format the JSON data (http://piwik.org/docs/tracking-api/reference/#toc-advanced-bulk-tracking-requests). It is much cleaner to send the request strings as array (although there might be a little overhead).

E.g. this is a completely valid request:

{
   "requests": [
      { idsite: 1, url: "http://example.org", action_name: "Test bulk log Pageview", rec: 1 },
      { idsite: 1, url: "http://example.net/test.htm", action_name: "Another bulk page view", rec:1 }
   ],
   "token_auth": "33dc3f2536d3025974cccb4b4d2d98f4"
}
@anonymous-matomo-user
Copy link

In 8c1fcc1: Fix authentication for bulk tracking

refs #4135

@mattab
Copy link
Member

mattab commented Sep 13, 2013

In 15dcd00: Fixes #4135 kuddos @halfdan for finding the bug & patch!

@halfdan halfdan added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. c: Security For issues that make Matomo more secure. Please report issues through HackerOne and not in Github.
Projects
None yet
Development

No branches or pull requests

3 participants