Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins define translations they need as a hook: Remove _js hack! #4151

Closed
diosmosis opened this issue Sep 12, 2013 · 13 comments
Closed

Plugins define translations they need as a hook: Remove _js hack! #4151

diosmosis opened this issue Sep 12, 2013 · 13 comments
Assignees
@sgiehl
Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.0

Comments

@diosmosis
Copy link
Member

Use an event that plugins can use to determine which translations should be available in JavaScript and load them all automatically.
@anonymous-matomo-user
Copy link

In a5ab907: Refs #4151, remove loadJavascriptTranslations twig function and automatically generate translation JS for all plugins. Translation JS is now treated as an asset and is included in merged JS.

Note:

  • Includes tweaks to capture.js: on webpage error stop capture program.

@anonymous-matomo-user
Copy link

In 3a2c5f4: Refs #4151, refactor translation JavaScript generation code and add event so plugins can specify which strings should be available client-side.

@anonymous-matomo-user
Copy link

In 807336d: Refs #4151, make sure translations JS is always regenerated when merged assets is disabled.

@anonymous-matomo-user
Copy link

In e88b30a: Refs #4151, make sure developing w/ merged assets disabled isn't a big pain.

@anonymous-matomo-user
Copy link

In 330bde5: Refs #4151, fix regression caused by refactoring hack.

@sgiehl
Copy link
Member

sgiehl commented Sep 14, 2013

In e0fd925: refs #4151 refactored some usages of _js hack

@sgiehl
Copy link
Member

sgiehl commented Sep 14, 2013

In 7589d30: refs #4151 refactored some more usages of _js hack

@sgiehl
Copy link
Member

sgiehl commented Sep 14, 2013

In 55cbbec: refs #4151 refactored some more usages of _js hack

@sgiehl
Copy link
Member

sgiehl commented Sep 14, 2013

In 2fa88c2: refs #4151 refacoted some more usages of _js hack

@sgiehl
Copy link
Member

sgiehl commented Sep 14, 2013

In 4cdb957: refs #4151 refactored more _js hack uses

@sgiehl
Copy link
Member

sgiehl commented Sep 14, 2013

In aa6bef2: refs #4151 refactored last usages of _js hack

@sgiehl
Copy link
Member

sgiehl commented Sep 14, 2013

In fd18ea2: fixes #4151 removed _js hack

@mattab
Copy link
Member

mattab commented Oct 16, 2013

Beautiful change guys...

@diosmosis diosmosis added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4151, remove loadJavascriptTranslations twig function…
a5ab907 
… and automatically generate translation JS for all plugins. Translation JS is now treated as an asset and is included in merged JS.

Note:
  - Includes tweaks to capture.js: on webpage error stop capture program.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4151, refactor translation JavaScript generation code…
3a2c5f4 
… and add event so plugins can specify which strings should be available client-side.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4151, make sure translations JS is always regenerated…
807336d 
… when merged assets is disabled.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4151, make sure developing w/ merged assets disabled …
e88b30a 
…isn't a big pain.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Refs matomo-org#4151, fix regression caused by refactoring hack.
330bde5
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl
refs matomo-org#4151 refactored some usages of _js hack
e0fd925
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl
refs matomo-org#4151 refactored some more usages of _js hack
7589d30
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl
refs matomo-org#4151 refactored some more usages of _js hack
55cbbec
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl
refs matomo-org#4151 refacoted some more usages of _js hack
2fa88c2
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl
refs matomo-org#4151 refactored more _js hack uses
4cdb957
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl
refs matomo-org#4151 refactored last usages of _js hack
aa6bef2
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl
fixes matomo-org#4151 removed _js hack
fd18ea2
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical. Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
4 participants
@diosmosis @mattab @sgiehl @anonymous-matomo-user