Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove file functions.php and only use static helpers #4202

Closed
mattab opened this issue Oct 7, 2013 · 10 comments
Closed

Remove file functions.php and only use static helpers #4202

mattab opened this issue Oct 7, 2013 · 10 comments
Assignees
@mattab
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.0

Comments

@mattab
Copy link
Member

mattab commented Oct 7, 2013

The file core/functions.php is a left over from the old days of not using namespaces. Let's remove these functions and instead, directly call the helpers.
@mattab
Copy link
Member Author

mattab commented Oct 9, 2013

In 4d34198: Refs #4202 removing functions Piwik_PostEvent and moving to Piwik::postEvent

@mattab
Copy link
Member Author

mattab commented Oct 9, 2013

In 6d46df5: Refs #4202 removing functions Piwik_GetOption and SetOption. Now use: Option::get and Option::set and Option::delete

@mattab
Copy link
Member Author

mattab commented Oct 9, 2013

In 81ccb29: Refs #4202 removing functions Piwik_Translate and Piwik_TranslateException

@mattab
Copy link
Member Author

mattab commented Oct 9, 2013

In 9c3a523: Refs #4202 fix build

@mattab
Copy link
Member Author

mattab commented Oct 9, 2013

In e9817e9: Refs #4202 Menu refactor GO. This one is tricky...

@mattab
Copy link
Member Author

mattab commented Oct 9, 2013

In 500373c: Refs #4202 Menu refactor GO. This one is tricky...

@mattab
Copy link
Member Author

mattab commented Oct 9, 2013

In 6cb020e: Refs #4202 Menu refactor done

@mattab
Copy link
Member Author

mattab commented Oct 9, 2013

In efa8f7a: Refs #4202 submodule trickery

@mattab
Copy link
Member Author

mattab commented Oct 9, 2013

NICE!

@mattab
Copy link
Member Author

mattab commented Oct 9, 2013

In 82695ac: Refs #4202 Cleaning up the good old bridge classes

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
@mattab mattab self-assigned this Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4202 removing functions Piwik_PostEvent and moving to…
4d34198 
… Piwik::postEvent
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4202 removing functions Piwik_GetOption and SetOption…
6d46df5 
…. Now use: Option::get and Option::set and Option::delete
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4202 removing functions Piwik_Translate and Piwik_Tra…
81ccb29 
…nslateException
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4202 fix build
9c3a523
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4202 Menu refactor GO. This one is tricky...
e9817e9
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4202 Menu refactor GO. This one is tricky...
500373c
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4202 Menu refactor done
6cb020e
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4202 submodule trickery
efa8f7a
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4202 Cleaning up the good old bridge classes
82695ac
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@mattab