Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Piwik.js javascript tests on continuous integration #4225

Closed
mattab opened this issue Oct 17, 2013 · 16 comments
Closed

Run Piwik.js javascript tests on continuous integration #4225

mattab opened this issue Oct 17, 2013 · 16 comments
Assignees
@tsteur
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
2.0

Comments

@mattab
Copy link
Member

mattab commented Oct 17, 2013

Currently the piwik.js javascript tests are executed manually after changes in the piwik.js

We should execute these tests on the continuous integration platform travis so that we know whenever the piwik.js is impacted.

After this improvement, all our tests will be automated! :)
@mattab
Copy link
Member Author

mattab commented Oct 17, 2013

In 1dc0e11: Fixing piwik.js tests and JSLint after realizing refs #4225

@mattab
Copy link
Member Author

mattab commented Oct 17, 2013

In 182e66f: Fixing piwik.js tests and JSLint after realizing refs #4225
(cherry picked from commit 1dc0e11)

@tsteur
Copy link
Member

tsteur commented Nov 25, 2013

In 487e542: refs #4225 use latest qunit version (1.12)

@tsteur
Copy link
Member

tsteur commented Nov 25, 2013

In c58dffe: refs #4225 added phantomjs testrunner which runs all qunit tests and displays the result as well as returns a proper return code

@tsteur
Copy link
Member

tsteur commented Nov 25, 2013

In effabcc: refs #4225 if we are running a testsuite, run the JS tests as well

@tsteur
Copy link
Member

tsteur commented Nov 25, 2013

In 9d61e7f: refs #4225 output testname, testmodule and error message in case of a failure

@tsteur
Copy link
Member

tsteur commented Nov 25, 2013

In 71bae47: refs #4225 run js tests in a separate group and other after each phpunit test

@tsteur
Copy link
Member

tsteur commented Nov 25, 2013

In 27a02ff: refs #4225 run js tests first as they are pretty fast

@tsteur
Copy link
Member

tsteur commented Nov 25, 2013

In 942df1d: refs #4225 more detailed error output

@tsteur
Copy link
Member

tsteur commented Nov 25, 2013

In 20d4c26: refs #4225 output expected and actual only if set

@tsteur
Copy link
Member

tsteur commented Nov 25, 2013

In c85ebdf: refs #4225 output alert messages

@tsteur
Copy link
Member

tsteur commented Nov 25, 2013

In bcf5eba: refs #4225 added simple documentation

@tsteur
Copy link
Member

tsteur commented Nov 25, 2013

In aebff02: refs #4225 updated documentation

@tsteur
Copy link
Member

tsteur commented Nov 25, 2013

In 8bb8fd4: refs #4225 fix js test in PhantomJS, will not work in browser... needs to be resolved. Tests should be green now

@tsteur
Copy link
Member

tsteur commented Nov 25, 2013

In 06ac8c0: refs #4225 sort object to make sure we get the same test results on PhantomJS, Webkit and any other browser

@mattab
Copy link
Member Author

mattab commented Nov 26, 2013

nice new addition to our Quality Assurance process... well done!!

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Fixing piwik.js tests and JSLint after realizing refs matomo-org#4225
1dc0e11
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Fixing piwik.js tests and JSLint after realizing refs matomo-org#4225
182e66f 
(cherry picked from commit 1dc0e11)
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4225 use latest qunit version (1.12)
487e542
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4225 added phantomjs testrunner which runs all qunit …
c58dffe 
…tests and displays the result as well as returns a proper return code
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4225 if we are running a testsuite, run the JS tests …
effabcc 
…as well
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4225 output testname, testmodule and error message in…
9d61e7f 
… case of a failure
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4225 run js tests in a separate group and other after…
71bae47 
… each phpunit test
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4225 run js tests first as they are pretty fast
27a02ff
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4225 more detailed error output
942df1d
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4225 output expected and actual only if set
20d4c26
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4225 output alert messages
c85ebdf
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4225 added simple documentation
bcf5eba
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4225 updated documentation
aebff02
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4225 fix js test in PhantomJS, will not work in brows…
8bb8fd4 
…er... needs to be resolved. Tests should be green now
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4225 sort object to make sure we get the same test re…
06ac8c0 
…sults on PhantomJS, Webkit and any other browser
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsteur tsteur

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
2 participants
@tsteur @mattab