Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Continuous Integration on MYSQLI #4233

Closed
mattab opened this issue Oct 22, 2013 · 9 comments
Closed

Enable Continuous Integration on MYSQLI #4233

mattab opened this issue Oct 22, 2013 · 9 comments
Assignees
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Oct 22, 2013

We do support MYSQLI but none of the team members actually use it. It may be broken and we wouldn't know it... However a lot of Piwik users are definitely using it in production...

The goal is to make our release process more agile and enjoy a more stable piwik for all.

Tasks:

  • Run tests suites (Core, Unit, Integration) on MYSQLI
    • on PHP 5.5 (we do not need to run it on all PHP versions as this may be too slow)
    • could we simply add mysqli to the current travis matrix build?
  • Investigate any bug that will be found once tests are running on MYSQLI on travis

Note:

  • it is out of scope to run the UI/screenshot tests on mysqli
@tsteur
Copy link
Member

tsteur commented Nov 13, 2013

In 3ad167a: refs #4233 for each env set testsuite and mysql_adapter

@tsteur
Copy link
Member

tsteur commented Nov 13, 2013

In 130be30: refs #4233 moving tests that require a database to integration as those are integration tests per se

@tsteur
Copy link
Member

tsteur commented Nov 13, 2013

In b2f0936: refs #4233 setting group on class level to make sure all tests within this class have this group

@tsteur
Copy link
Member

tsteur commented Nov 13, 2013

In 1839649: refs #4233 fix class name

@tsteur
Copy link
Member

tsteur commented Nov 13, 2013

In 5c8ba40: refs #4233 fix log tests

@tsteur
Copy link
Member

tsteur commented Nov 13, 2013

I ran tests locally with PHPUnit and configured travis to run Integration tests (which make use of DB) to use MYSQLI beside PDO

@mattab
Copy link
Member Author

mattab commented Nov 13, 2013

  • The whole build depends on the "sed" command to work OK. TO be sure we always run the build correctly, can you add following test:

    read $MYSQL_ADAPTER
    if PDO, test the current adapter is PDO
    if mysqli, test the current adapter is Mysqli
    else: test should fail

This way we make sure the travis really runs the right adapter and we will remember to change the build setting if we change the setting name or adapter name etc.

@tsteur
Copy link
Member

tsteur commented Nov 13, 2013

In b89bed1: refs #4233 make sure value is either pdo or mysqli

@tsteur
Copy link
Member

tsteur commented Nov 13, 2013

In 3755bfa: refs #4233 check if it creates the correct instance

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…ion as those are integration tests per se
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Development

No branches or pull requests

2 participants