Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: full screen embed dashboard shows Menu behind calendar #4234

Closed
mattab opened this issue Oct 22, 2013 · 11 comments
Closed

Regression: full screen embed dashboard shows Menu behind calendar #4234

mattab opened this issue Oct 22, 2013 · 11 comments
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Milestone

Comments

@mattab
Copy link
Member

mattab commented Oct 22, 2013

See attached file, the embed dashboard (via link in "Widgets") shows the menu behind the calendar.

Reproduce:

  • create a few custom dashboards.
  • open index.php?module=CoreHome&action=index&idSite=1&period=day&date=yesterday#module=Dashboard&action=embeddedIndex&idSite=1&period=day&date=yesterday&idDashboard=3
  • Got: see screenshot
  • Expected: menu should be shown on the right of the calendar.

(Note to self: let's add a UI test for the embed dashboard)

@mattab
Copy link
Member Author

mattab commented Oct 22, 2013

Attachment:
Embed dashboard menu displayed behind.png

@mattab
Copy link
Member Author

mattab commented Nov 2, 2013

Attachment: opera date range
opera .png

@tzi
Copy link
Member

tzi commented Nov 4, 2013

Thanks.

I'll have a look.

An online demo of this bug:

@mattab
Copy link
Member Author

mattab commented Nov 5, 2013

@mattab
Copy link
Member Author

mattab commented Nov 5, 2013

Attachment:
chome missing space.png

@mattab
Copy link
Member Author

mattab commented Nov 5, 2013

Feedback

  • Nice refactor & cleanup!
  • Missing some space between dashboard names.
    • There used to be a square-list element before each dashboard name which was maybe a good thing?

not a regression but while we're at it

@mattab
Copy link
Member Author

mattab commented Nov 6, 2013

  • see attached screenshot. URL -> the calendar + segments DIV are on top of each other
  • the "Widgets & Dashboard" DIV should only display on the dashboard and not on other reports.

@mattab
Copy link
Member Author

mattab commented Nov 6, 2013

Attachment:
widgets collapsed.png

@tzi
Copy link
Member

tzi commented Nov 8, 2013

Hi!

I commited new corrections:

  • The "Widgets & Dashboard" is hidden on non-dashboard board
  • Noramly prevent the metrics picker to get at the top of the dashboard. But it's hard to reproduce
  • I bring back the black square list. It is the only widget using it, so are you sure?

Cheers!
Thomas.

@mattab
Copy link
Member Author

mattab commented Nov 11, 2013

In 9ebb3b1: Refs #4234 Fix z-index of calendar so it appears on top of segment editor

@mattab
Copy link
Member Author

mattab commented Nov 19, 2013

Thanks it looks great!

we are now eagerly waiting to hear about the new theme #4127

@tzi do you plan any cool updates (Left menu click, etc.) in coming weeks?

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. Major Indicates the severity or impact or benefit of an issue is much higher than normal but not critical.
Projects
None yet
Development

No branches or pull requests

2 participants