-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Segment Editor: request should timeout when it takes too long to generate auto suggested values #4253
Comments
it works for us on piwik.org but we do not have 10,000 pages indeed. what is the error in your server error logs ? |
Technically there is no Piwik error on the server Matt. It's the web browser that gets impatient and send a "Page unresponsive" after waiting too long. A quick fix (I can't provide since I'm no coder, sadly) would be to add a "no ajax query in segment editor". BTW, we also get the infamous "Page unresponsive" when trying to use Segment Editor with IP filtering because Piwik tries to help us by filling the field from many thousands of IP that went at our door... Small websites will not have such trouble but Government' ones (lots of different users and more than 1000 pages) will always do. |
It was reported in #4509 as well: Running v2.0.2 |
If you need to work around the issue, you can use the latest beta version, disable the "Live" plugin, and then the segment editor will work. |
Realistically, this is clearly a bug: It crashes and prevent users from creating segment. We should find a solution to this issue, some ideas of possible solutions:
|
I don't speak fluent ajax but maybe introduce some kind of timout "if we reach 10 seconds to get back data, disable autocomplete". Or a manual "stop autocomplete" at the right side of any field in segment editor (IP , Page name and URL are those common). Anything to make Segment Editor usable in large websites. Dali |
@daliDev: Do you still experience "Page unresponsive" issues with the latest 2.2.1 release? I had a look at the API which returns max 30 results. This is implemented already for a longer time so there "shouldn't" be any "page unresponsive" issues. Otherwise I decreased the limit a little bit which should make it slightly faster on the server side and added a request timeout of 20seconds on the client side. |
Thomas, my server doesn't see the internet, auto-update isn't possible. Since I got +50k pageviews a day I don't upgrade too often. I'm at 2.2.0 at the moment. So I'm limited in quick feedback on recent fixes. Pretty sorry about that. But looks good on paper. ;) Dali |
Ok we experience the same issue on demo.piwik.org. The request for auto-suggest takes 2 minutes or so, and if I click on "Save & Apply" before the end of that request, then the "SegmentEditor.add" request is queued and waiting for auto-suggest response to come back. Here is proposed solution:
|
See #5121 New config setting to disable segment auto complete |
Thanks for the new feature for sites with 10 000 URLs... This is appreciated. Dali |
So we can close this ticket? |
…r the autocomplete request (20seconds). If it is not loaded after 20 seconds
…y 30 values kept anyway
When you got a website with more than 10 000 pages, using the Segment editor with "Page URL" makes it erratic.
The ajax call to gets that many URLs takes more than a minute and produce a "Page unresponsive" with Chrome. And I'm on a dedicated PHP/Piwik machine with MySQL on another.
Maybe there should be a check by Piwik to see if there's more than 200 urls to not try to fill the area and let us fill it manually?
Keywords: Segment editor
The text was updated successfully, but these errors were encountered: