Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geoip DB automatic update doesn't respect update period #4263

Closed
hpvd opened this issue Oct 31, 2013 · 29 comments
Closed

geoip DB automatic update doesn't respect update period #4263

hpvd opened this issue Oct 31, 2013 · 29 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@hpvd
Copy link

hpvd commented Oct 31, 2013

geoip DB automatic update doesn't respect update period
please see attachement

seen in piwik 2.0 pre beta 3 (from github master)

@hpvd
Copy link
Author

hpvd commented Oct 31, 2013

Attachment:
2013-10-31_22h53_10.png

@hpvd
Copy link
Author

hpvd commented Oct 31, 2013

update period selection was untouched for several months (updating from Piwik 1.12...)

@hpvd
Copy link
Author

hpvd commented Nov 5, 2013

no update yet, please see new attachment...

@hpvd
Copy link
Author

hpvd commented Nov 5, 2013

Attachment:
2013-11-05_19h37_16.png

@mattab
Copy link
Member

mattab commented Nov 7, 2013

Thanks for the report!

@diosmosis do you have any idea about this bug?

@hpvd
Copy link
Author

hpvd commented Nov 7, 2013

add screenshot with the setting...

@hpvd
Copy link
Author

hpvd commented Nov 7, 2013

Attachment:
Piwik Administration1.png

@hpvd
Copy link
Author

hpvd commented Nov 14, 2013

updated this morning to piwik 2.0b5

last update date is still the same 10.10.2013

=> the update was also not perfomed simply within the wrong period (e.g. every month, instead of the selected "every week")
=> the update process still seem not to work in general

@diosmosis
Copy link
Member

In 250a832: Fixes #4263, make sure GeoIPAutoUpdater forces new scheduled time of update task to be persisted when update period is set.

@hpvd
Copy link
Author

hpvd commented Dec 16, 2013

now piwik 2.0 RC2 is installed - no update yet. Last one was 10/10/2013
Updated to nearly every new beta in the meantime...
Please see attachment.

@hpvd
Copy link
Author

hpvd commented Dec 16, 2013

Attachment:
2013-12-16_21h22_10.png

@hpvd
Copy link
Author

hpvd commented Dec 16, 2013

maybe a button "update now" + good error messages would be helpful to find the problem...

@diosmosis
Copy link
Member

Changing the period doesn't immediately start the update. Did you change from monthly to weekly? In that case the next update should be this week (on the 20th based on the last time it was run). Otherwise it will be next month.

Admittedly, this isn't the best solution. Having an 'update now' link would be good, but due to the way MaxMind hosts their databases, it's not easy to do this through the browser.

In the meantime, I think rescheduling to the next cron run (if the database is out of date) and having a message that displays the next scheduled run time would be a good idea.

@hpvd
Copy link
Author

hpvd commented Dec 17, 2013

changed in both directions several times during the last month piwik/betas..

Shouldn't it update /respect the periods even without any changes??

yes your idea to show the next scheduled update date is great!
=> new Ticket?
and the "update now button" another one for a future milestone?

@hpvd
Copy link
Author

hpvd commented Dec 21, 2013

updated to piwik 2.02 => still no update.
Last update was still 10-10-2013

@nullnull-00
Copy link
Contributor

Attachment:
PIWIK.PNG

@nullnull-00
Copy link
Contributor

Attachment:
FTP.PNG

@nullnull-00
Copy link
Contributor

I found something even more strange in my Piwik installation.
It seems that not only the update does not work as expected(see PIWIK.PNG), but that also the given date (here march 2013) is wrong, because the file actually was changed in august 2013(see FTP.PNG).

PS I'm sure the file has not been modified by anything else than Piwik.

@diosmosis
Copy link
Member

In 6a60bcd: Refs #4263, fix bugs in geoip auto updater, show next scheduled time for updater in admin screen and refactor the updater a bit.

@diosmosis
Copy link
Member

In d1b6596: Refs #4263, display next scheduled run time for geoip updater task, make sure updater is run in next cron run if a file is out of date, & forgot to commit new file in last commit.

@diosmosis
Copy link
Member

In 77ea9ff: Fixes #4263, fix bug in weekly scheduled time period and fix bugs in last commit.

@mattab
Copy link
Member

mattab commented Jan 17, 2014

@hpvd
Copy link
Author

hpvd commented Jan 17, 2014

many thanks for pointing to the plugin.

After install (in piwik 2.04b1) it shows something really weird:

  • there are two tasks regarding geoip update
  • both are on different dates and
  • both are in the past (2013)

Piwik_UserCountry_GeoIPAutoUpdater.update October 16, 2013 00:00 (in 271 Tage -8756 Stunden)
GeoIPAutoUpdater.update December 18, 2013 00:00 (in 334 Tage -8756 Stunden)

please see attachment

In addition the last update from geoip updater shows still 10-10-2013 (today is January 17th 2014 and setting is weekly update)

please see other attachment

@hpvd
Copy link
Author

hpvd commented Jan 17, 2014

Attachment:
2014-01-17_20h04_51.png

@hpvd
Copy link
Author

hpvd commented Jan 17, 2014

Attachment:
2014-01-17_20h19_11.png

@hpvd
Copy link
Author

hpvd commented Feb 5, 2014

maybe this is depend from this:
#4612
?

@mattab
Copy link
Member

mattab commented Feb 6, 2014

Removing owner from tickets. from now on, I suggest we assign tickets to ourselves for cases when we we plan to actively work on them in the coming days/weeks. let's discuss if needed during our team call.

@hpvd
Copy link
Author

hpvd commented Feb 8, 2014

finally fixed by fixing:
#4612

see also:
#4652

now everything works fine!

@mattab
Copy link
Member

mattab commented Feb 8, 2014

In a27a417: Fixes #4263 geoip automatic updates are working for me with latest git, even in webcron. please reopen if: the next update is scheduled in the future properly, but the updater is not running.

@hpvd hpvd added this to the 2.1 - Piwik 2.1 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…d time of update task to be persisted when update period is set.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…uled time for updater in admin screen and refactor the updater a bit.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…er task, make sure updater is run in next cron run if a file is out of date, & forgot to commit new file in last commit.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
… latest git, even in webcron. please reopen if: the next update is scheduled in the future properly, but the updater is not running.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

4 participants