Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor ArchiveProcessor & Plugins Archiver mechanism #4278

Closed
mattab opened this issue Nov 5, 2013 · 16 comments
Closed

refactor ArchiveProcessor & Plugins Archiver mechanism #4278

mattab opened this issue Nov 5, 2013 · 16 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.0

Comments

@mattab
Copy link
Member

mattab commented Nov 5, 2013

To prepare for #4124 and #4139 and some other features (MultiSites) refactoring of core ArchiveProcessor and Archiver classes is required.

In particular:

  • rename for consistency
  • remove need for ArchiveProcessor.Day and .Period hooks
  • rename the concept of "Period" archiving to be more generic of "Aggregate Multiple Reports"
@mattab
Copy link
Member Author

mattab commented Nov 5, 2013

In e8bec08: Refs #4278 Remove Archiver hooks and the classes Archiver will be automatically detected.

@mattab
Copy link
Member Author

mattab commented Nov 5, 2013

In 670b24f: Refs #4278 Remove shouldArchive, make getMinTimeArchiveProcessed protected

@mattab
Copy link
Member Author

mattab commented Nov 5, 2013

In 09b56ba: Refs #4278 make isArchiveTemporary protected

@mattab
Copy link
Member Author

mattab commented Nov 5, 2013

In 8a6fad6: Refs #4278 Simplifying ArchiveProcessor: moving internal logic to ArchiveProcessor\Loader
ArchiveProcessor becomes a helper class easier to understand for plugin developers

@mattab
Copy link
Member Author

mattab commented Nov 5, 2013

In 74b8175: Refs #4278 Simplifying ArchiveProcessor

@mattab
Copy link
Member Author

mattab commented Nov 5, 2013

In 16fb491: Refs #4278 Cleanup these Parameters objects

@mattab
Copy link
Member Author

mattab commented Nov 6, 2013

In f3fcfa6: Refs #4278 Creating a new class PluginsArchiver to refactor logic out of ArchiveProcessor\Loader

@mattab
Copy link
Member Author

mattab commented Nov 8, 2013

In 25e7a79: Refs #4278 breaking down functions

@mattab
Copy link
Member Author

mattab commented Nov 8, 2013

In 74226f6: Refs #4278

  • Moving Core visit metrics archiving logic to PluginsArchiver which is consistent
  • Cutting down code that should be unused after refactoring

@mattab
Copy link
Member Author

mattab commented Nov 8, 2013

In 8d5b609: Refs #4278 Breaking the if statements

@mattab
Copy link
Member Author

mattab commented Nov 8, 2013

In ffce42a: Refs #4278 I broke the build, don't know why yet

@mattab
Copy link
Member Author

mattab commented Nov 13, 2013

In f197294: Refs #4278 Rewriting aggregateNumericMetrics() to use DataTable aggregation only (code reuse)

@mattab
Copy link
Member Author

mattab commented Nov 13, 2013

In 0518d45: Refs #4278 to process unique visitors, isSingleSite() is required (no unique visitors cross-sites for now)

@mattab
Copy link
Member Author

mattab commented Nov 15, 2013

In c6d2177: refs #4278 Renames + New hook to let plugins modify idSites to archive

@mattab
Copy link
Member Author

mattab commented Nov 18, 2013

In 9471ce3: Refs #4278 Removing transformMetadata()

@mattab
Copy link
Member Author

mattab commented Nov 19, 2013

This is done. I'm happy with the result of ArchiveProcessor\Loader \PluginsArchiver and main ArchiveProcessor classes. They make sense to me at least, which was not the case before I started on this quest ;)

We will revisit work on archiving as part of 2.1 and these tickets:

we created docs for ArchiveProcessor:

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4278 Remove Archiver hooks and the classes Archiver w…
e8bec08 
…ill be automatically detected.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4278 Remove shouldArchive, make getMinTimeArchiveProc…
670b24f 
…essed protected
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4278 make isArchiveTemporary protected
09b56ba
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4278 Simplifying ArchiveProcessor: moving internal lo…
8a6fad6 
…gic to ArchiveProcessor\Loader

ArchiveProcessor becomes a helper class easier to understand for plugin developers
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4278 Simplifying ArchiveProcessor
74b8175
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4278 Cleanup these Parameters objects
16fb491
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4278 Creating a new class PluginsArchiver to refactor…
f3fcfa6 
… logic out of ArchiveProcessor\Loader
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4278 breaking down functions
25e7a79
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4278
74226f6 
 * Moving Core visit metrics archiving logic to PluginsArchiver which is consistent
 * Cutting down code that should be unused after refactoring
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4278 Breaking the if statements
8d5b609
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4278 I broke the build, don't know why yet
ffce42a
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4278 Continue refactoring, removing the function's fl…
1086707 
…ag parameter
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4278 Rewriting aggregateNumericMetrics() to use DataT…
f197294 
…able aggregation only (code reuse)
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4278 to process unique visitors, isSingleSite() is re…
0518d45 
…quired (no unique visitors cross-sites for now)
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
refs matomo-org#4278 Renames + New hook to let plugins modify idSites…
c6d2177 
… to archive
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refactor const to highlight their coupling matomo-org#4278
884e22d
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4278 Removing transformMetadata()
9471ce3
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@mattab