Ticket #43 (new New feature)

Opened 2 years ago

Last modified 10 days ago

Plugin to exclude the webmaster based on IP or IP range

Reported by: matt Owned by:
Priority: critical Milestone: 1 - Piwik 0.5.6
Component: Core Keywords:
Cc: Sensitive: no

Description (last modified by matt) (diff)

We want to be able to exclude a list of IPs, and/or a list of IP ranges (using *.*.123.34 notation) from being tracked by Piwik.

The list of IPs to exclude would be stored in the website cache file (where goals and alias URLs are stored).

In the UI, the feature should be available

  • general exclusion list (only available to the super user): would apply to all website registered in Piwik, would need their own cache file (that applies to all websites)
  • for each website, we can define a list of IPs. All IPs in this list + in the general list are checked at each Piwik request.

As an inline help, the UI would show the user current IP that he could copy paste in the list.

The UI would call the API in JSON (like the existing screens).

The UI for this feature should be designed to be part of a "preference page" for a website, as we need to add several new preferences for each website: #41, #42, #43, #56. Ideally, all the UI would be ajax (very quick to go from the list of websites in the admin UI, to load one website details page, to come back to the list of websites).

Outstanding question: should it be in the SiteManager plugin, or a new plugin? Should it be part of the core (to minimize overhead of loading plugins at Tracker time...)

Change History

Changed 2 years ago by matt

  • description modified (diff)

Changed 2 years ago by matt

  • milestone set to Future features

Changed 17 months ago by matt

  • milestone changed from Future features to DigitalVibes

Changed 14 months ago by vipsoft

Changed 14 months ago by vipsoft

Changed 14 months ago by vipsoft

  • milestone changed from DigitalVibes to Surviving The Wild

Changed 12 months ago by matt

  • priority changed from major to critical
  • milestone changed from Surviving The Wild to DigitalVibes

Changed 10 months ago by matt

  • component changed from Plugins to Core

Changed 7 months ago by albass

Changed 7 months ago by vipsoft

  • sensitive unset

There's a special case where the IP (or IP range) to be excluded falls within these reserved ranges:

  • 10.0.0.0 - 10.255.255.255
  • 172.16.0.0 - 172.31.255.255
  • 192.168.0.0 - 192.168.255.255

I'm going to roll the requirements in from #567. Visitors with HTTP_CLIENT_IP or HTTP_X_FORWARDED_FOR, IP addresses in the private IP address ranges should instead use the first public address in the list, falling back to $_SERVER['REMOTE_ADDR'].

Also, it looks like there are a couple of unreachable codepaths in the current implementation of getIp() which should be reviewed.

Changed 6 months ago by vipsoft

  • owner set to vipsoft

Changed 6 months ago by matt

  • description modified (diff)

Changed 6 months ago by matt

  • description modified (diff)

Changed 6 months ago by matt

  • description modified (diff)

Changed 6 months ago by vipsoft

In  http://forum.piwik.org/index.php?showtopic=1540 there's a mod to Provider to map local IP addresses to internal "provider" names, eg "net1", "net2", ...

Changed 6 months ago by vipsoft

  • owner vipsoft deleted

Changed 3 months ago by matt

  • milestone changed from 2 - Piwik 0.6 - DigitalVibes to 1 - Piwik 0.5.5

this has become by far the most requested feature - receiving messages twice a day asking for this feature. We should push it in the product.

Changed 10 days ago by matt

  • milestone changed from 1 - Piwik 0.5.5 to 1 - Piwik 0.5.6
Note: See TracTickets for help on using tickets.