Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Activate/Deactivate plugins and themes super fast! #4373

Closed
mattab opened this issue Dec 10, 2013 · 8 comments
Closed

Make Activate/Deactivate plugins and themes super fast! #4373

mattab opened this issue Dec 10, 2013 · 8 comments
Assignees
@julienmoumne
Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Milestone
2.0

Comments

@mattab
Copy link
Member

mattab commented Dec 10, 2013

When Activating or deactivating a plugin, on the new page view, the Javascript and CSS file will be re-processed. Currently it takes up to 20 secondes (ouch)! This is because the JS and CSS files are huge in size: they include all core files, as well as third party plugins files.

Proposed solution:

  • All JS and CSS from "Core" plugins (see method isPluginBundledWithCore) is stored in the getJs and getCSs as currently
  • All JS and CSS from "Third Party plugins" are located in a new getJsPlugins and getCssPlugins

This new file is very small (since there are few third party plugins, especially atm). This file is easy and fast to re-process.

Notes:

  • When a Core plugin is enabled/disabled, delete core css+js files.
  • When a third party plugin is enabled/disabled, delete new plugin css+js file
  • Check that enabling/disabling plugins will only re-process the two small css/js files, therefore clicking should be 1-2 seconds at most.
@julienmoumne
Copy link
Member

Dividing Less files would remove the ability for third-party plugins to override global Less variables.

Furthermore, most of the time is spent in minifying JavaScript files.

We will only separate JavaScript files.

An additional improvement will be committed :activating/deactivating plugins without JavaScript files will no longer trigger a full merging process.

@anonymous-matomo-user
Copy link

In 6624e27: fixes #4373, #1640

@mattab
Copy link
Member Author

mattab commented Dec 19, 2013

it's now slick to enable third party plugins & themes...
Very impressive change, full test driven, very well done Julien!

@mattab
Copy link
Member Author

mattab commented Dec 19, 2013

fbd4675

Refs #1640 Adding jshrink to LEGALNOTICE + update help text

@mattab
Copy link
Member Author

mattab commented Dec 19, 2013

In 3910272: Refs #4373 The getAssets calls the dispatcher with a plugin that cannot be loaded. catching exception when trying to "uninstall" the plugin.

@tsteur
Copy link
Member

tsteur commented Jan 28, 2014

In ca4779f: refs #4373 fixes the merged assets file was only generate if it did not exist before and fix it also was not regenerated if a plugin was not updated. Therefore include the version number in the cache buster.

@tsteur
Copy link
Member

tsteur commented May 16, 2014

In 8e9f6fc: refs #4373 I had to make this change to force reloading the css in case the compiled css changes without a version change

Following scenario:
There is a plugin that generates css/less files dynamically from time to time but the Plugin version does not change as there is no plugin update. Only the less file changes. When the less file changes, the plugin deletes the merged asset file as well.

The current cache buster is based on Piwik version + Plugin versions. That means, when a less file changes but no version the browser will still use the "cached CSS" as the cache buster does not change.

Therefore I have to build a cacheBuster value based on the content of the compiled CSS file to invalidate the cached CSS file in the browser and to force the reloading. As far as I can see this change does not have any huge performance implications as it builds a hash based on the already compiled CSS file and only tries to regenerate the compiled CSS file if it does not exist.

@tsteur
Copy link
Member

tsteur commented May 16, 2014

In 6f325aa: refs #4373 somehow my previous commit did not work. need this method public for my previous change in the view

@mattab mattab added this to the 2.0 - Piwik 2.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@julienmoumne
fixes matomo-org#4373, matomo-org#1640
6624e27
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4373 The getAssets calls the dispatcher with a plugin…
3910272 
… that cannot be loaded. catching exception when trying to "uninstall" the plugin.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4373 fixes the merged assets file was only generate i…
ca4779f 
…f it did not exist before and fix it also was not regenerated if a plugin was not updated. Therefore include the version number in the cache buster.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4373 I had to make this change to force reloading the…
8e9f6fc 
… css in case the compiled css changes without a version change

Following scenario:
There is a plugin that generates css/less files dynamically from time to time but the Plugin version does not change as there is no plugin update. Only the less file changes. When the less file changes, the plugin deletes the merged asset file as well.

The current cache buster is based on Piwik version + Plugin versions. That means, when a less file changes but no version the browser will still use the "cached CSS" as the cache buster does not change. 

Therefore I have to build a cacheBuster value based on the content of the compiled CSS file to invalidate the cached CSS file in the browser and to force the reloading. As far as I can see this change does not have any huge performance implications as it builds a hash based on the already compiled CSS file and only tries to regenerate the compiled CSS file if it does not exist.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@tsteur
refs matomo-org#4373 somehow my previous commit did not work. need th…
6f325aa 
…is method public for my previous change in the view
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@julienmoumne julienmoumne

Labels
Enhancement For new feature suggestions that enhance Matomo's capabilities or add a new report, new API etc.
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
4 participants
@tsteur @mattab @julienmoumne @anonymous-matomo-user