You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
That overwrites the default (Zeitgeist?) that just sets 40px height.
I think: As not all Logos (e.g. branding) are made equal concerning their height the CSS shouldn't impose an aspect ratio by setting width and height to a fixed size (the size of the piwik logo). The same accounts for the absoulte height: not all logos work visually in 20px height. The Morpheus theme has space for max 50px high logos, but that looks to dense. The 40px default does in fact make sense.
My suggestion (logically, not directly CSS):
set a max-height instead of a fixed height (prevents smaller logos from being blown up to uglyness)
preserve aspect ratio (like Zeitgeist does)
center the logo vertically (not via setting a fixed "margin-top" that works only for the piwik logo).
I just played around with using the (much more powerful and elegant) CSS background-* possibilities. They're nice, but finally not ideal because the width is unknown and the clickable area shouldn't be bigger or smaller than the logo.
A possible quick-fix could be to agree on a bigger fixed logo height (e.g. 34px like the current piwik raw logo file is), remove the width CSS and crack the the vertical-centering nut later.
PS: Same applies to the login screen, would be nice if the logo appears bigger there.
Keywords: theme, branding
The text was updated successfully, but these errors were encountered:
(found in 2.0.1)
The Morpheus theme currently sets a fixed height and width to the logo in the main interface:
That overwrites the default (Zeitgeist?) that just sets 40px height.
I think: As not all Logos (e.g. branding) are made equal concerning their height the CSS shouldn't impose an aspect ratio by setting width and height to a fixed size (the size of the piwik logo). The same accounts for the absoulte height: not all logos work visually in 20px height. The Morpheus theme has space for max 50px high logos, but that looks to dense. The 40px default does in fact make sense.
My suggestion (logically, not directly CSS):
Implementation of the vertical centering is a mess although. Vertical centering is one of the uglier areas of CSS (see http://www.vanseodesign.com/css/vertical-centering/ for all of its "beauty").
I just played around with using the (much more powerful and elegant) CSS background-* possibilities. They're nice, but finally not ideal because the width is unknown and the clickable area shouldn't be bigger or smaller than the logo.
A possible quick-fix could be to agree on a bigger fixed logo height (e.g. 34px like the current piwik raw logo file is), remove the width CSS and crack the the vertical-centering nut later.
PS: Same applies to the login screen, would be nice if the logo appears bigger there.
Keywords: theme, branding
The text was updated successfully, but these errors were encountered: