Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segment selector UI regression #4459

Closed
hpvd opened this issue Dec 29, 2013 · 14 comments
Closed

Segment selector UI regression #4459

hpvd opened this issue Dec 29, 2013 · 14 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@hpvd
Copy link

hpvd commented Dec 29, 2013

period selector looks broken in piwik 2.03 b3 and firefox 27

please see attachment

@hpvd
Copy link
Author

hpvd commented Dec 29, 2013

Attachment:
2013-12-29_17h33_38.png

@hpvd
Copy link
Author

hpvd commented Dec 29, 2013

sorry of course it's not the period selector, but the segment selector...

@mattab
Copy link
Member

mattab commented Dec 31, 2013

What exactly is the problem? it looks OK to me

@hpvd
Copy link
Author

hpvd commented Jan 5, 2014

the problem was the strange coloured bar - see old attachment.

Seems to be resulting from long segment-names

Looks much better within 2.03b4
but there is still room for improvement.
Please see new attachment.

Maybe one could optimize the position of the line break between "name" and "[edit]"-link
by always giving the "edit" enough room:
one idea would be to shorten the room for the name so that there is always enough room in every line for "edit) (looking like an own column for it)
and allow or even force a line break with the name and set the edit link always in the last line of each name.
please see third attachment

@hpvd
Copy link
Author

hpvd commented Jan 5, 2014

Attachment: 2.03b4
2014-01-05_12h33_42.png

@hpvd
Copy link
Author

hpvd commented Jan 5, 2014

Attachment: idea
2014-01-05_12h37_52.png

@mattab
Copy link
Member

mattab commented Jan 6, 2014

In 67eeee4: Make segment selector bit wider + truncate segment name earlier, to fix the visual display bug (even in German language)
Fixes #4459

@hpvd
Copy link
Author

hpvd commented Jan 7, 2014

sorry have to reopen this.

just tested latest green master from github

Looks different and better but a little broken (in German language)

  • [is ndern and there is not enough room for this word
  • strange coloured bar is back again

=> please see latest attachment

@hpvd
Copy link
Author

hpvd commented Jan 7, 2014

Attachment:
2014-01-07_11h42_49.png

@mattab
Copy link
Member

mattab commented Jan 9, 2014

@capedfuzz thanks for investigating, I'm not sure how to fix this visual bug in Morpheus, in German language, when there are 5-10 segments including some long ones..

@diosmosis
Copy link
Member

In 092cbf5: Refs #4459, tweak css of segment edit link, avoid overflow.

@diosmosis
Copy link
Member

I can't reproduce the strange color bar, if it reoccurs please state the OS you're using and whether you see it in different browsers.

@hpvd
Copy link
Author

hpvd commented Jan 9, 2014

looks good now in 2.03b6!
browser is FF 26
OS windows 7

@mattab
Copy link
Member

mattab commented Jan 9, 2014

Marking as fixed!

@hpvd hpvd added this to the 2.0.3 - Piwik 2.0.3 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
…ix the visual display bug (even in German language)

Fixes matomo-org#4459
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants