Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove DoNotTrack and Anonymize plugins and move them to PrivacyManager #4493

Closed
mattab opened this issue Jan 9, 2014 · 7 comments
Closed

Remove DoNotTrack and Anonymize plugins and move them to PrivacyManager #4493

mattab opened this issue Jan 9, 2014 · 7 comments
Assignees
@diosmosis
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.0.3

Comments

@mattab
Copy link
Member

mattab commented Jan 9, 2014

The DoNotTrack plugin is a small plugin. Enabling / disabling DoNotTrack is done by enabling/disabling the plugin. I would prefer if DNT was a setting in the config file, and so enabling/disabling would not require plugin enable/disable.
@diosmosis
Copy link
Member

In fb5454b: Fixes #4493, move DoNotTrack & AnonymizeIP logic to PrivacyManager plugin. Includes modification to EventDipatcher to allow generic callbacks in getListHooksRegistered method.

@sgiehl
Copy link
Member

sgiehl commented Jan 11, 2014

In 755013d: refs #4493 renamed translation key

@mattab
Copy link
Member Author

mattab commented Jan 12, 2014

feedback:

  • I think we must make sure they are never laoded (events executed) or displayed in the manage plugins page (in case we can't write the config on upgrade). Otherwise we could have the new DNT and the old running at the same time.... Maybe we blacklist these two plugins?
  • an error reported in the forums http://forum.piwik.org/read.php?2,109744 Call to undefined method Piwik\Plugins\PrivacyManager\Controller::isDntSupported()

@mattab
Copy link
Member Author

mattab commented Jan 13, 2014

In 14dbfac: Refs #4493 Function was renamed

@mattab
Copy link
Member Author

mattab commented Jan 13, 2014

In a665821: Fix jsProxyTest, ie. make tracker work refs #4493
Why include file manually? because piwik.php does not use autoloader yet.
Maybe as part of refs #4074 we could setup autoloader for piwik.php / tracking API.

@mattab
Copy link
Member Author

mattab commented Jan 13, 2014

In bb65f51: Fixes #4493 Make sure tracker cache also contain the Anonymizer IP settings + debug output

@mattab
Copy link
Member Author

mattab commented Jan 13, 2014

In 8a6d8c4: Refs #4493 Typo

@mattab mattab added this to the 2.0.3 - Piwik 2.0.3 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
Fixes matomo-org#4493, move DoNotTrack & AnonymizeIP logic to Privacy…
fb5454b 
…Manager plugin. Includes modification to EventDipatcher to allow generic callbacks in getListHooksRegistered method.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@sgiehl
refs matomo-org#4493 renamed translation key
755013d
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4493 Function was renamed
14dbfac
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Fix jsProxyTest, ie. make tracker work refs matomo-org#4493
a665821 
Why include file manually? because piwik.php does not use autoloader yet.
Maybe as part of refs matomo-org#4074 we could setup autoloader for piwik.php / tracking API.
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Fixes matomo-org#4493 Make sure tracker cache also contain the Anonym…
bb65f51 
…izer IP settings + debug output
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4493 Typo
8a6d8c4
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@diosmosis diosmosis

Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.0.3
Development

No branches or pull requests
3 participants
@diosmosis @mattab @sgiehl