Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase width of "label" table #453

Closed
anonymous-matomo-user opened this issue Dec 2, 2008 · 12 comments
Closed

Increase width of "label" table #453

anonymous-matomo-user opened this issue Dec 2, 2008 · 12 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.

Comments

@anonymous-matomo-user
Copy link

Is there a way to increase the width of the the label/unique visitor table so that more words show instead of the …

Is there a hovering feature that will show popup the full length of the word?

Pic attached for reference
Keywords: wishlist

@anonymous-matomo-user
Copy link
Author

Attachment:
[ticket.JPG](http://issues.piwik.org/attachments/453/ticket.JPG)

@robocoder
Copy link
Contributor

Matt’s plan is to use jquery truncate. See ticket #159.

@robocoder
Copy link
Contributor

#159 didn't fix this issue, so I'm re-opening for investigation, i.e., is it possible to truncate to the visible width of the table cell (instead of the fixed string length truncation (which results in the first 30 characters + '...')?

@mattab
Copy link
Member

mattab commented Apr 7, 2010

Anthon,
I agree, your suggestion is how things should work. For example, GA tables have the label end of string disappear when the browser window is set to lower width. I think it is using overflow:hidden;. We would then deprecate jquery truncate.

@robocoder
Copy link
Contributor

I'm leaving this in the 0.7 milestone as this bears more investigation and cross-browser testing.

For example, Firefox doesn't natively support overflow:hidden in a table unless the table layout has fixed-width columns. As I understand it, this is "by design", due to the way the table reflow algorithm is implemented.

I tested 3 other jquery plugins that truncate text to the container width, but none overcame the above table limitation. These were tested outside of Piwik using a simple multi-column table (auto layout).

Note: Piwik has an additional hurdle: the data table has not been added/rendered to the DOM yet when the cosmetics are applied, so the computed width is 0.

@mattab
Copy link
Member

mattab commented Apr 9, 2010

Interesting. Did you try the case where inside the TD label, there is a DIV containing the label, that has the css overflow attribute?

@robocoder
Copy link
Contributor

Firefox ignores the overflow:hidden and auto-expands the table so that it's wider than the css width:450px that I set on the table. This is the auto-layout/reflow logic at work.

@robocoder
Copy link
Contributor

Ditto for IE8.

The jquery.textoverflow plugin is interesting, but it requires that the table already be rendered, so there's a flash as it restyles the table. Sort of works with FF (width calculation is off when table has borders); doesn't work at all in IE8.

@mattab
Copy link
Member

mattab commented May 6, 2010

I see... the way piwik builds table is an issue. we should probably instead have the ajax return pure json, and the JS do the full rendering. This would be much cleaner and easier to maintain, but it is not trivial to change all the code to work this way.

What would be great would be to have the label hidden just when the second column starts, and have possibility to double click to select (and eg. copy) the full label (including the hidden part). Again, I don't know if this is possible...

For example, Firefox doesn't natively support overflow:hidden in a table unless the table layout has fixed-width columns. As I understand it, this is "by design", due to the way the table reflow algorithm is implemented.

Maybe we could we set fixed width to columns? Would that break something?

@robocoder
Copy link
Contributor

Deferring again. I don't see a cross browser solution here. Setting the table-layout:fixed is ugly (all the columns are the same width).

@anonymous-matomo-user
Copy link
Author

In PIWIK 1.0, we can display entire "Pages titles" by adding
" 'actionToLoad' => 'getPageTitles&'"
in plugins/Actions/Actions.php (l 138)

The entire line :
Piwik_AddMenu('Actions_Actions', 'Actions_SubmenuPageTitles', array('module' => 'Actions', 'action' => 'getPageTitles', 'actionToLoad' => 'getPageTitles&

@mattab
Copy link
Member

mattab commented Jan 6, 2011

ch33k0n, what are you talking about?

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc. wontfix If you can reproduce this issue, please reopen the issue or create a new one describing it.
Projects
None yet
Development

No branches or pull requests

3 participants