Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comments still referencing old Piwik_ (before using PHP 5.3 namespaces) #4609

Closed
mattab opened this issue Feb 1, 2014 · 6 comments
Closed

Remove comments still referencing old Piwik_ (before using PHP 5.3 namespaces) #4609

mattab opened this issue Feb 1, 2014 · 6 comments
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Milestone
2.1

Comments

@mattab
Copy link
Member

mattab commented Feb 1, 2014

I did a global search in the codebase and found hundreds of cases of Piwik_XYZ written in the codebase, mostly in comments, such as Piwik_Auth, Piwik_Db, Piwik_API, etc.

We should remove these references and replace with correct phpdoc blocks (or simply remove).

This would conclude our effort of migrating the whole codebase from pre-namespace to full namespace support (see also: #4074 )
@anonymous-matomo-user
Copy link

In b1ae26d: Removing occurences of Piwik_ in core/

  • @subpackage is deprecated
  • @Package must only occur once
  • @Package supports nesting (and can match the namespace)

refs #4609

@halfdan
Copy link
Member

halfdan commented Feb 2, 2014

It's worth reading up on http://www.phpdoc.org/docs/latest/for-users/phpdoc/tags/package.html

Both @category and @subpackage are deprecated. @Package should only be used if it does not match the namespace. Also @Package must not appear more than once in a file.

I suggest the following:

  • for core/ we remove @Package
  • for plugins/ we use @Package with the name of the plugin (and not the namespace - so Actions instead of Piwik\Plugins\Actions)

Feedback?

@anonymous-matomo-user
Copy link

In f9d52ca: Remove all occurences of @Package / @subpackage / @category from core/ files.

refs #4609

@anonymous-matomo-user
Copy link

In 6b9ae92: Remove remaining @package/@subpackage/@category declarations from plugins/

fixes #4609

@anonymous-matomo-user
Copy link

In dde7c37: Removing last Piwik_ occurences

refs #4609

@mattab
Copy link
Member Author

mattab commented Feb 3, 2014

In 217b22b: Fixes #4609 Removing last mentions of Piwik_ -- Looking sharp now!

@mattab mattab added this to the 2.1 - Piwik 2.1 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan
Removing occurences of Piwik_ in core/
b1ae26d 
  * @subpackage is deprecated
  * @Package must only occur once
  * @Package supports nesting (and can match the namespace)

refs matomo-org#4609
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan
Remove all occurences of @Package / @subpackage / @category from core…
f9d52ca 
…/ files.

refs matomo-org#4609
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan
Remove remaining @package/@subpackage/@category declarations from plu…
6b9ae92 
…gins/

fixes matomo-org#4609
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@halfdan
Removing last Piwik_ occurences
dde7c37 
refs matomo-org#4609
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Fixes matomo-org#4609 Removing last mentions of Piwik_ -- Looking sha…
217b22b 
…rp now!
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task Indicates an issue is neither a feature nor a bug and it's purely a "technical" change.
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
3 participants
@halfdan @mattab @anonymous-matomo-user