New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Archive.php use PHP CLI instead of Web, more reliable / performant #4610
Comments
In 279a4d6: refs #4610 I moved the Lock class to CliMulti as it does not 100% work on windows and is only used in CliMulti so far. As the Lock class can be quite useful and maybe needed in other use cases it would be nice to have it somewhere under core or so as it is not directly related to CLI. We might have to move it later again. Need to find a better solution for windows |
Great work Thomas, we believe this ticket is now implemented. Please report if you have any feedback or issue! |
…d, tests and fixes for output class
…ows (yet), save locks in a separate folder
…t 100% work on windows and is only used in CliMulti so far. As the Lock class can be quite useful and maybe needed in other use cases it would be nice to have it somewhere under core or so as it is not directly related to CLI. We might have to move it later again. Need to find a better solution for windows
…do not have to bootstrap everything again and we already make sure it is only executed from the command line
…leanup later, some other optimizations
…tream" which happens if a subprocess tries to write to a file and the archiver just tries to file_get_content at the same time. So file_exists returned true just a few ms before but while trying to read it fails
…ish it as the process probably will not start anyway
…arked as finished meanwhile
…ws, redirect the output of php to get output even if piwik exits
… as one could assume it works on all systems etc. Only use it for archiving for now
…I, only in the archive.php run
The implementation of our Cron Archive script should use Php CLI instead of doing Http requests to the webserver. This would remove one system in the middle and should make archive script slightly more reliable.
Because the piwik.php webcron also uses the CronArchive logic then either we change this logic, or keep the CURL wrapper in the CronArchive (when Php CLI not available or exec() disabled).
The text was updated successfully, but these errors were encountered: