Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Custom Events should not trigger a conversion for Goal defined as matching an "Outlink" #4659

Closed
nkuehn opened this issue Feb 10, 2014 · 4 comments
Closed

Custom Events should not trigger a conversion for Goal defined as matching an "Outlink" #4659

nkuehn opened this issue Feb 10, 2014 · 4 comments
Assignees
@mattab
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone
2.2.0

Comments

@nkuehn
Copy link

nkuehn commented Feb 10, 2014

If you have cofigured a goal that's triggered serverside via "external Link", that goal is triggered by tracking any event. Events aren't mapped to any goals because you can't do that yet.

I have set up an empty Piwik website profile with nothing but that goal configured:

Goal config:

  • external link
  • url contains "/" (i.e. all urls)
  • allow to convert multple times (makes no difference in my case)

Other types of Goals (manual / clientside, Download, ...) aren't triggered by events in my installation.

Can someone reproduce that? It's quite a blocker for me to start tracking events to have the data once the UI is there.
Keywords: event goal 2.0.3
@mattab
Copy link
Member

mattab commented Feb 11, 2014

I dont know if I understand correctly. Are you saying that, Custom Events are triggering Goal conversions, for Goal defined as matching an "Outlink" ?

If so, it sounds like a bug. please confirm what you mean VS what you expect to see. thanks

@nkuehn
Copy link
Author

nkuehn commented Feb 11, 2014

Yes, you're right, your wording "Custom Events are triggering Goal conversions, for Goal defined as matching an "Outlink"" is what I wanted to say.

I just can't tell whether it's in the way I'm using piwik or a core bug.

If you tell me the PHP Class to start debugging in I can try to provide technically more specific feedback.

@mattab
Copy link
Member

mattab commented Mar 16, 2014

In ab58fe9: Fixes #4659 Fix if statement logic ftw.
Let's see if build is still passing

@mattab
Copy link
Member

mattab commented Mar 16, 2014

In a875e38: Refs #4659 Add test case for it

@nkuehn nkuehn added this to the 2.2.0 - Piwik 2.2.0 milestone Jul 8, 2014
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Fixes matomo-org#4659 Fix if statement logic ftw.
ab58fe9 
Let's see if build is still passing
sabl0r pushed a commit to sabl0r/piwik that referenced this issue Sep 23, 2014
@mattab
Refs matomo-org#4659 Add test case for it
a875e38
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mattab mattab

Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
2 participants
@mattab @nkuehn