Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for plugin updates - broken? #4703

Closed
hpvd opened this issue Feb 18, 2014 · 11 comments
Closed

check for plugin updates - broken? #4703

hpvd opened this issue Feb 18, 2014 · 11 comments
Assignees
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Milestone

Comments

@hpvd
Copy link

hpvd commented Feb 18, 2014

Hi

Updating of plugins works fine before 2.1 RC
Now there seem to be no notification for new versions of plugins.

Please see example in attachment.

When is the status of a plugin (up to date / update available) checked?

Login logout doesn't solve it

@hpvd
Copy link
Author

hpvd commented Feb 18, 2014

Attachment:
2014-02-18_07h03_26.png

@hpvd
Copy link
Author

hpvd commented Feb 18, 2014

hmm time doesn't help:
still no notification e.g.for the 1.03 security info plugin (1.02 is installed)
Not in the menu, not in the plugin table
using piwik 2.1RC3, and php 5.3.27

@hpvd
Copy link
Author

hpvd commented Feb 19, 2014

updated to RC4 => still no notification for available update...

@hpvd
Copy link
Author

hpvd commented Feb 19, 2014

Since I check for updates of Piwik and its plugins once a day and install them directly if they are available,
update notification seems not to work at least since feb 12th.
Please see attachment with new found of not up to date plugins...

@hpvd
Copy link
Author

hpvd commented Feb 19, 2014

Attachment:
2014-02-19_21h39_48.png

@mattab
Copy link
Member

mattab commented Feb 20, 2014

Thanks for the report, we could reproduce. Maybe we will only fix after 2.1 release. Cheers

@hpvd
Copy link
Author

hpvd commented Feb 21, 2014

There seem to be changes with RC8.

  • Available updates are shown in menu again: (number)
  • but no updates are shown in table

please see attachment

@hpvd
Copy link
Author

hpvd commented Feb 21, 2014

Attachment:
2014-02-21_17h23_42.png

@hpvd
Copy link
Author

hpvd commented Feb 21, 2014

after installing an update and reloading the page with the plugin table again: the notification on the top of the table is also back...

@hpvd
Copy link
Author

hpvd commented Feb 24, 2014

with RC9 update notification doesn't work any-more again (same as before RC8).
Only in RC8 it was temporally working nearly fine again...

@tsteur
Copy link
Member

tsteur commented Feb 24, 2014

Fixed. All plugins on the Marketplace must have a valid semantic version number, otherwise it failed. In this case an old version of the PleineLune plugin was used which did not have any version number specified. So the core version number was used which was not a valid semantic version. I do now catch such errors to make sure the plugin update check still works for plugins having a valid version number but ignoring plugins having an invalid version number since those plugins are not installed via the marketplace.

It only occurred if someone installed a plugin manually having the same name as a plugin on the marketplace but used an invalid version number.

@hpvd hpvd added this to the 2.1 - Piwik 2.1 milestone Jul 8, 2014
@tsteur tsteur modified the milestones: 2.4.0 - Piwik 2.4.0, 2.1 - Piwik 2.1 Jul 11, 2014
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For errors / faults / flaws / inconsistencies etc.
Projects
None yet
Development

No branches or pull requests

3 participants