Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve manufacturer detection #4792

Closed
anonymous-matomo-user opened this issue Mar 3, 2014 · 3 comments
Closed

Improve manufacturer detection #4792

anonymous-matomo-user opened this issue Mar 3, 2014 · 3 comments
Assignees
@sgiehl
Labels
detection improvements enhancement P: normal
Milestone
Version 2.8

Comments

@anonymous-matomo-user
Copy link

You can improve your brand detection parsing the last 6 digits (normally) in the user agent (before plugins).
In this website there is a very nice catalog: http://www.whatismybrowser.com/developers/unknown-user-agent-fragments

"Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.2; WOW64; Trident/6.0; Touch; MAARJS)" --> Acer

"Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.2; Trident/6.0; Touch; MASMJS)" --> Samsung

I can contribute sending hundred thousand of user agents from different countries if you need it for general testing
Keywords: manufacturer brand
@sgiehl
Copy link
Member

sgiehl commented Apr 29, 2014

Would you please send the list to stefan[at]piwik.org. Would be helpful for testing and improving the detections.

@anonymous-matomo-user
Copy link
Author

Will send it during this week.

I will export it from different countries

@anonymous-matomo-user anonymous-matomo-user added this to the Version 2.2 milestone Jul 8, 2014
@sgiehl sgiehl changed the title Improve manufacturer detection in UserAgentParserEnhanced Improve manufacturer detection Jul 8, 2014
@sgiehl sgiehl removed this from the Version 2.2 milestone Jul 8, 2014
@sgiehl sgiehl removed the C: Core label Jul 9, 2014
@sgiehl sgiehl added this to the Long Term milestone Aug 6, 2014
@sgiehl
Copy link
Member

sgiehl commented Dec 31, 2014

Another source for those fragments: http://user-agents.me/windows-oem-manufacturer-list

sgiehl added a commit that referenced this issue Jan 1, 2015
@sgiehl
refs #4792 - added detection of vendor fragments
b8803fb
sgiehl added a commit that referenced this issue Jan 1, 2015
@sgiehl
refs #4792 - added tests for vendor fragments
228a3b3
@sgiehl sgiehl modified the milestones: Version 2.8, Long Term Jan 1, 2015
@sgiehl sgiehl self-assigned this Jan 1, 2015
@sgiehl sgiehl closed this as completed Jan 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgiehl sgiehl

Labels
detection improvements enhancement P: normal
Projects
None yet
Milestone
Version 2.8
Development

No branches or pull requests
2 participants
@sgiehl @anonymous-matomo-user